Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate and create follow ups on todo's and fixme's within the code base #142

Open
Nicoretti opened this issue May 25, 2022 · 0 comments
Open
Labels
refactoring Code improvement without behavior change

Comments

@Nicoretti
Copy link
Member

Evaluate and create follow ups on todo's and fixme's within the code base.

Possible Actions for todo's and fixme's

Remove todo or fixme from the code base

This can be the case because e.g.:

  1. It is unclear what the intend behind a todo/fixme was
  2. PM decides as long still is no impact on the users (e.g. bug report) we remove it
  3. It looks low to non impact especially in the context of it's age and the absence of reported issues

⚠️ Whatever the case for removing will be, make sure you mention the reason for the removal within the commit message.

Create a ticket to track the todo or fixme

In cases where addressing a todo/fixme will be a significant piece of work, create a explicit GitHub issue for it.

Address the todo or fixme in the context of this ticket

Small changes to address todo's or fixme's can be done in the context of this ticket by creating a PR related to this ticket.

Open Todo's and Fixme's

⚠️ Before you start, validate that no further todo or fixme have been added, e.g. by runnig the following command(s):

grep -ir fixme .
grep -ir todo .

or

rg -i fixme .
rg -i todo .

Fixme's

./test/test_suite.py
97:        """FIXME: test skipped to allow upgrading to SQLAlchemy 1.3.x due

./sqlalchemy_exasol/base.py
619:            # FIXME: Missing type support: INTERVAL DAY [(p)] TO SECOND [(fp)], INTERVAL YEAR[(p)] TO MONTH

Todo's

./test/test_exasol.py
333:        #TODO: check that reflected table object is identical

./test/test_deadlock.py
13:# TODO: get_schema_names, get_view_names and get_view_definition didn't cause deadlocks in this scenario
52:        # TODO: Doesnt produce a deadlock anymore since last commit?
88:        # TODO: think of other scenarios where metadata deadlocks with view could happen
96:        # TODO: think of other scenarios where metadata deadlocks with view could happen

./requirements_test.txt
2:pytest>=3.1.0,<5.4 #TODO: test run fails with 5.4

./sqlalchemy_exasol/base.py
148:    # INTERVAL DAY [(p)] TO SECOND [(fp)] TODO: missing support for EXA Datatype, check Oracle Engine
149:    # INTERVAL YEAR[(p)] TO MONTH         TODO: missing support for EXA Datatype, check Oracle Engine
229:        # TODO: FKs that reference other tables could be inlined
470:        # TODO: set isolation level
659:                # TODO: we have to possibility to encode the current identity value count
@Nicoretti Nicoretti added feature Product feature refactoring Code improvement without behavior change labels May 25, 2022
@redcatbear redcatbear removed the feature Product feature label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

No branches or pull requests

2 participants