Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version information to slc #751

Open
tomuben opened this issue Feb 2, 2023 · 1 comment
Open

Add version information to slc #751

tomuben opened this issue Feb 2, 2023 · 1 comment
Labels
feature Product feature

Comments

@tomuben
Copy link
Collaborator

tomuben commented Feb 2, 2023

Background

Currently, the only way to discover the version of a (pre-)installed SLC is to search for the SLC directory in the (default) BucketFS.

The slc connection string for the preinstalled SLC, which can be found in the database system tables, is like:

PYTHON=builtin_python R=builtin_r JAVA=builtin_java PYTHON3=builtin_python3

-> It does not contain any useful information.

We should somehow store the version information when creating a release SLC under /build_info and optionally provide an UDF in exa-toolbox which prints the version stored under /build_info.

Acceptance Criteria

Under discussion

  1. Extend docker_build task with new parameter version, which then will be copied to /build_info
  2. Adjust script-languages-container-ci to forward the version info to build and release.
@tomuben tomuben added the feature Product feature label Feb 2, 2023
@tkilias
Copy link
Collaborator

tkilias commented Mar 13, 2023

We already have the option build_name in the build command of the SLCs. https://github.com/exasol/script-languages-container-tool/blob/8aa7493f9b8a17a293790d638148a4a62887c249/exasol_script_languages_container_tool/cli/commands/build.py

The main issue is that we need to set this parameter in the AWS CodeBuild Release Workflow with the correct version of the SLCs. This version is available via the pyproject.toml of the SLC repo. However, we need to provide the package name to the slc-ci, because if we split the slc repo this name can be different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Product feature
Projects
None yet
Development

No branches or pull requests

2 participants