Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dummy os executor #214

Open
tomuben opened this issue May 21, 2024 · 0 comments
Open

Remove dummy os executor #214

tomuben opened this issue May 21, 2024 · 0 comments
Labels
refactoring Code improvement without behavior change

Comments

@tomuben
Copy link
Collaborator

tomuben commented May 21, 2024

Background

Currently, as workaround, we have a DummyOsExecutor (in task TestRunnerDBTestTask) which is a fallback when the environment info is incomplete, which can happen if ITDE's SpawnTestEnvironment was launched for an external database. See exasol/integration-test-docker-environment#403
After the linked issue is fixed, we can remove the DummyOsExecutor and adapt the test DockerRunDBTestExternalDBTest, which then will need to manage the SSH file.

Acceptance Criteria

  1. Use latest version of ITDE with fix for SpawnTestEnvironment for external database cannot be used with SSH executor integration-test-docker-environment#403
  2. Remove the DummyOsExecutor in (in task TestRunnerDBTestTask)
  3. Simplify TestRunnerDBTestTask._executor_factory()
  4. Adapt the test DockerRunDBTestExternalDBTest
    • Use f"--db-os-access {DbOsAccess.SSH.name}" for run-db-test command
    • Manage the SSH Key file of the (external) docker db and add to run-db-test command the user and key-file
@tomuben tomuben added the refactoring Code improvement without behavior change label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

No branches or pull requests

1 participant