Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename connections.open_bucketfs_connection(...) to open_bucketfs_bucket(...) #38

Open
ahsimb opened this issue Nov 30, 2023 · 1 comment
Open

Rename connections.open_bucketfs_connection(...) to open_bucketfs_bucket(...) #38

ahsimb opened this issue Nov 30, 2023 · 1 comment
Assignees
@ahsimb
Labels
refactoring Code improvement without behavior change

Comments

@ahsimb
Copy link
Collaborator

ahsimb commented Nov 30, 2023

The current name suggests that the returned object is a bucketfs Service.
@ahsimb ahsimb added the refactoring Code improvement without behavior change label Nov 30, 2023
@ahsimb ahsimb self-assigned this Nov 30, 2023
@ahsimb ahsimb mentioned this issue Nov 30, 2023
Merged
@tkilias
Copy link
Collaborator

tkilias commented Aug 26, 2024

@ahsimb I think, we should move the notebook-connector and ai-lab to the BucketFS-Python Pathlike interface. I think, it is in general the better interface for users. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahsimb ahsimb

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkilias @ahsimb