Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ignorance of DB version used in tests #149

Open
Shmuma opened this issue Dec 19, 2024 · 0 comments · May be fixed by #150
Open

Fix the ignorance of DB version used in tests #149

Shmuma opened this issue Dec 19, 2024 · 0 comments · May be fixed by #150
Assignees
Labels
bug Unwanted / harmful behavior

Comments

@Shmuma
Copy link
Contributor

Shmuma commented Dec 19, 2024

As I discovered recently, --db-version parameter we set in github workflows is ignored and all the integration tests are running against the default ITDE DB version (8.18.1 at the moment).

This need to be fixed by passing the version via environment variable and use it on ITDE startup.
As long-term solution, we can migrate to pytest-plugins for all tests, but it might be done in a separate task

@Shmuma Shmuma added the bug Unwanted / harmful behavior label Dec 19, 2024
@Shmuma Shmuma changed the title Fix the DB version used in tests Fix the ignorance of DB version used in tests Dec 19, 2024
@Shmuma Shmuma self-assigned this Dec 19, 2024
@Shmuma Shmuma linked a pull request Dec 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unwanted / harmful behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant