Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a outlier screening step #107

Open
WardLT opened this issue Sep 20, 2023 · 1 comment
Open

Add a outlier screening step #107

WardLT opened this issue Sep 20, 2023 · 1 comment

Comments

@WardLT
Copy link
Collaborator

WardLT commented Sep 20, 2023

ASE's CP2K wrapper does not warn if computations fail to converge. So, we'll get the occasional redox energy that uses an unconverged energy value.

In lieu of fixing ASE (not yet sure how), we should add an outlier screening step to prevent these bad energy values from interfering with learning.

@WardLT
Copy link
Collaborator Author

WardLT commented Sep 25, 2023

It seems that most of the failures involve SCCS computations. Should we increase the EPS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant