From 3d791c2102e9c280c199dd3c9fcdc0c5aae4420b Mon Sep 17 00:00:00 2001 From: Kyle Wong <69778837+kwongz@users.noreply.github.com> Date: Thu, 9 Jan 2025 11:51:41 -0500 Subject: [PATCH] Revert "Release release-2025-01-09" --- .changeset/blue-sloths-sort.md | 5 - .changeset/clever-avocados-punch.md | 5 - .changeset/cool-weeks-hang.md | 5 - .changeset/five-bottles-worry.md | 5 - .changeset/green-jeans-hide.md | 5 - .changeset/sour-kings-move.md | 5 - .changeset/twelve-toes-serve.md | 5 - .changeset/wise-papayas-clap.md | 5 - .github/workflows/e2e.yml | 6 + .github/workflows/tests.yml | 4 + .prettierignore | 1 - e2e/hmr/tests/tests.spec.js | 28 -- .../lib/preprocess/src/process-queries.cjs | 5 - .../plugins/datasources/cli/edit/Options.js | 1 - .../datasources/cli/edit/Options.spec.js | 117 ------ .../lib/universal-sql/src/build-parquet.js | 11 - .../inputs/button-group/ButtonGroup.svelte | 8 +- .../lib/atoms/inputs/checkbox/Checkbox.svelte | 2 +- .../atoms/inputs/date-input/_DateInput.svelte | 2 +- .../atoms/inputs/date-range/DateRange.svelte | 4 +- .../lib/atoms/inputs/dropdown/Dropdown.svelte | 2 +- .../lib/atoms/inputs/slider/_Slider.svelte | 6 +- .../lib/atoms/inputs/text/TextInput.svelte | 6 +- .../dimension-grid/DimensionCut.svelte | 12 +- .../dimension-grid/DimensionRow.svelte | 10 +- .../layout/EvidenceDefaultLayout.svelte | 3 - .../organisms/layout/sidebar/Sidebar.svelte | 128 +------ .../lib/unsorted/ui/BigLink.stories.svelte | 2 +- .../src/lib/unsorted/ui/BigLink.svelte | 49 ++- .../lib/unsorted/ui/LinkButton.stories.svelte | 1 - .../src/lib/unsorted/ui/LinkButton.svelte | 25 +- .../src/lib/unsorted/ui/Modal.stories.svelte | 24 -- .../src/lib/unsorted/ui/Modal.svelte | 97 +---- .../lib/unsorted/viz/core/SearchBar.svelte | 7 +- .../viz/table/DataTable.stories.svelte | 103 +++++- .../lib/unsorted/viz/table/_DataTable.svelte | 98 +++-- .../docs/pages/build-your-first-app/index.md | 30 +- .../components/{ui => }/accordion/index.md | 0 .../pages/components/{ui => }/alert/index.md | 0 .../pages/components/all-components/index.md | 344 +++++++++--------- .../{charts => }/annotations/index.md | 2 +- .../{charts => }/area-chart/index.md | 6 +- .../components/{maps => }/area-map/index.md | 2 +- .../{charts => }/bar-chart/index.md | 6 +- .../components/{maps => }/base-map/index.md | 6 +- .../components/{ui => }/big-link/index.md | 4 +- .../components/{data => }/big-value/index.md | 4 +- .../components/{charts => }/box-plot/index.md | 6 +- .../{charts => }/bubble-chart/index.md | 6 +- .../components/{maps => }/bubble-map/index.md | 0 .../{inputs => }/button-group/index.md | 0 .../{charts => }/calendar-heatmap/index.md | 6 +- .../components/{inputs => }/checkbox/index.md | 0 .../component-queries.md} | 5 - .../index.md | 6 +- .../{charts => }/custom-echarts/index.md | 2 +- sites/docs/pages/components/custom/index.md | 6 - .../components/{data => }/data-table/index.md | 4 +- sites/docs/pages/components/data/index.md | 5 - .../{inputs => }/date-input/index.md | 0 .../{inputs => }/date-range/index.md | 0 .../components/{data => }/delta/index.md | 0 .../components/{ui => }/details/index.md | 0 .../{inputs => }/dimension-grid/index.md | 0 .../{ui => }/download-data/index.md | 0 .../components/{inputs => }/dropdown/index.md | 0 .../{charts => }/echarts-options/index.md | 2 +- .../{charts => }/funnel-chart/index.md | 6 +- .../pages/components/{ui => }/grid/index.md | 0 .../components/{charts => }/heatmap/index.md | 6 +- .../{charts => }/histogram/index.md | 8 +- .../components/{charts => index}/index.md | 4 +- sites/docs/pages/components/inputs/index.md | 5 - .../{ui => }/last-refreshed/index.md | 0 .../{charts => }/line-chart/index.md | 6 +- .../components/{ui => }/link-button/index.md | 4 +- sites/docs/pages/components/maps/index.md | 5 - .../{charts => }/mixed-type-charts/index.md | 8 +- .../pages/components/{ui => }/modal/index.md | 0 .../components/{maps => }/point-map/index.md | 0 .../{ui => }/print-format-components/index.md | 0 .../{charts => }/sankey-diagram/index.md | 4 +- .../{charts => }/scatter-plot/index.md | 8 +- .../components/{inputs => }/slider/index.md | 0 .../{charts => }/sparkline/index.md | 2 +- .../pages/components/{ui => }/tabs/index.md | 0 .../{inputs => }/text-input/index.md | 0 sites/docs/pages/components/ui/index.md | 5 - .../components/{maps => }/us-map/index.md | 8 +- .../components/{data => }/value/index.md | 2 +- .../pages/core-concepts/components/index.md | 6 +- .../pages/core-concepts/data-sources/index.md | 2 +- .../docs/pages/core-concepts/filters/index.md | 2 +- .../docs/pages/core-concepts/queries/index.md | 8 +- .../docs/pages/core-concepts/syntax/index.md | 2 +- .../core-concepts/templated-pages/index.md | 2 +- .../docs/pages/core-concepts/themes/index.md | 12 +- .../{self-host => }/aws-amplify/index.md | 4 +- .../azure-static-apps/index.md | 2 +- .../{configuration => }/base-paths/index.md | 2 +- sites/docs/pages/deployment/cloud/index.md | 7 - .../{self-host => }/cloudflare-pages/index.md | 4 +- .../pages/deployment/configuration/index.md | 4 - .../{configuration => }/environments/index.md | 0 .../{cloud => }/evidence-cloud/index.md | 0 .../{self-host => }/firebase/index.md | 0 .../{self-host => }/github-pages/index.md | 5 +- .../{self-host => }/gitlab-pages/index.md | 4 +- .../hugging-face-spaces/index.md | 0 .../{self-host => }/netlify/index.md | 4 +- sites/docs/pages/deployment/overview/index.md | 26 +- .../rendering-modes/index.md | 0 .../docs/pages/deployment/self-host/index.md | 5 - .../{self-host => }/vercel/index.md | 0 .../guides/usql-migration-guide/index.md | 301 +++++++++++++++ sites/docs/pages/index.md | 2 +- .../pages/plugins/component-plugins/index.md | 9 +- .../pages/plugins/source-plugins/index.md | 11 +- sites/docs/pages/reference/layouts/index.md | 27 -- sites/docs/pages/reference/markdown/index.md | 10 +- sites/docs/partials/evidence-cloud.md | 2 +- sites/example-project/src/pages/+page.md | 4 - .../src/pages/settings/+page.server.js | 2 - sites/test-env/pages/nullish-dates.md | 14 - .../sources/needful_things/nullish_dates.sql | 6 - vercel.json | 119 +++--- 126 files changed, 899 insertions(+), 1044 deletions(-) delete mode 100644 .changeset/blue-sloths-sort.md delete mode 100644 .changeset/clever-avocados-punch.md delete mode 100644 .changeset/cool-weeks-hang.md delete mode 100644 .changeset/five-bottles-worry.md delete mode 100644 .changeset/green-jeans-hide.md delete mode 100644 .changeset/sour-kings-move.md delete mode 100644 .changeset/twelve-toes-serve.md delete mode 100644 .changeset/wise-papayas-clap.md delete mode 100644 packages/ui/core-components/src/lib/unsorted/ui/Modal.stories.svelte rename sites/docs/pages/components/{ui => }/accordion/index.md (100%) rename sites/docs/pages/components/{ui => }/alert/index.md (100%) rename sites/docs/pages/components/{charts => }/annotations/index.md (99%) rename sites/docs/pages/components/{charts => }/area-chart/index.md (96%) rename sites/docs/pages/components/{maps => }/area-map/index.md (99%) rename sites/docs/pages/components/{charts => }/bar-chart/index.md (97%) rename sites/docs/pages/components/{maps => }/base-map/index.md (97%) rename sites/docs/pages/components/{ui => }/big-link/index.md (79%) rename sites/docs/pages/components/{data => }/big-value/index.md (99%) rename sites/docs/pages/components/{charts => }/box-plot/index.md (96%) rename sites/docs/pages/components/{charts => }/bubble-chart/index.md (96%) rename sites/docs/pages/components/{maps => }/bubble-map/index.md (100%) rename sites/docs/pages/components/{inputs => }/button-group/index.md (100%) rename sites/docs/pages/components/{charts => }/calendar-heatmap/index.md (95%) rename sites/docs/pages/components/{inputs => }/checkbox/index.md (100%) rename sites/docs/pages/components/{custom/component-queries/index.md => custom-components/component-queries.md} (98%) rename sites/docs/pages/components/{custom/custom-component => custom-components}/index.md (98%) rename sites/docs/pages/components/{charts => }/custom-echarts/index.md (99%) delete mode 100644 sites/docs/pages/components/custom/index.md rename sites/docs/pages/components/{data => }/data-table/index.md (99%) delete mode 100644 sites/docs/pages/components/data/index.md rename sites/docs/pages/components/{inputs => }/date-input/index.md (100%) rename sites/docs/pages/components/{inputs => }/date-range/index.md (100%) rename sites/docs/pages/components/{data => }/delta/index.md (100%) rename sites/docs/pages/components/{ui => }/details/index.md (100%) rename sites/docs/pages/components/{inputs => }/dimension-grid/index.md (100%) rename sites/docs/pages/components/{ui => }/download-data/index.md (100%) rename sites/docs/pages/components/{inputs => }/dropdown/index.md (100%) rename sites/docs/pages/components/{charts => }/echarts-options/index.md (99%) rename sites/docs/pages/components/{charts => }/funnel-chart/index.md (95%) rename sites/docs/pages/components/{ui => }/grid/index.md (100%) rename sites/docs/pages/components/{charts => }/heatmap/index.md (97%) rename sites/docs/pages/components/{charts => }/histogram/index.md (94%) rename sites/docs/pages/components/{charts => index}/index.md (70%) delete mode 100644 sites/docs/pages/components/inputs/index.md rename sites/docs/pages/components/{ui => }/last-refreshed/index.md (100%) rename sites/docs/pages/components/{charts => }/line-chart/index.md (97%) rename sites/docs/pages/components/{ui => }/link-button/index.md (83%) delete mode 100644 sites/docs/pages/components/maps/index.md rename sites/docs/pages/components/{charts => }/mixed-type-charts/index.md (97%) rename sites/docs/pages/components/{ui => }/modal/index.md (100%) rename sites/docs/pages/components/{maps => }/point-map/index.md (100%) rename sites/docs/pages/components/{ui => }/print-format-components/index.md (100%) rename sites/docs/pages/components/{charts => }/sankey-diagram/index.md (99%) rename sites/docs/pages/components/{charts => }/scatter-plot/index.md (96%) rename sites/docs/pages/components/{inputs => }/slider/index.md (100%) rename sites/docs/pages/components/{charts => }/sparkline/index.md (99%) rename sites/docs/pages/components/{ui => }/tabs/index.md (100%) rename sites/docs/pages/components/{inputs => }/text-input/index.md (100%) delete mode 100644 sites/docs/pages/components/ui/index.md rename sites/docs/pages/components/{maps => }/us-map/index.md (97%) rename sites/docs/pages/components/{data => }/value/index.md (99%) rename sites/docs/pages/deployment/{self-host => }/aws-amplify/index.md (92%) rename sites/docs/pages/deployment/{self-host => }/azure-static-apps/index.md (95%) rename sites/docs/pages/deployment/{configuration => }/base-paths/index.md (87%) delete mode 100644 sites/docs/pages/deployment/cloud/index.md rename sites/docs/pages/deployment/{self-host => }/cloudflare-pages/index.md (94%) delete mode 100644 sites/docs/pages/deployment/configuration/index.md rename sites/docs/pages/deployment/{configuration => }/environments/index.md (100%) rename sites/docs/pages/deployment/{cloud => }/evidence-cloud/index.md (100%) rename sites/docs/pages/deployment/{self-host => }/firebase/index.md (100%) rename sites/docs/pages/deployment/{self-host => }/github-pages/index.md (92%) rename sites/docs/pages/deployment/{self-host => }/gitlab-pages/index.md (87%) rename sites/docs/pages/deployment/{self-host => }/hugging-face-spaces/index.md (100%) rename sites/docs/pages/deployment/{self-host => }/netlify/index.md (97%) rename sites/docs/pages/deployment/{configuration => }/rendering-modes/index.md (100%) delete mode 100644 sites/docs/pages/deployment/self-host/index.md rename sites/docs/pages/deployment/{self-host => }/vercel/index.md (100%) create mode 100644 sites/docs/pages/guides/usql-migration-guide/index.md delete mode 100644 sites/test-env/pages/nullish-dates.md delete mode 100644 sites/test-env/sources/needful_things/nullish_dates.sql diff --git a/.changeset/blue-sloths-sort.md b/.changeset/blue-sloths-sort.md deleted file mode 100644 index 680a69aa01..0000000000 --- a/.changeset/blue-sloths-sort.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@evidence-dev/preprocess': patch ---- - -fix query HMR diff --git a/.changeset/clever-avocados-punch.md b/.changeset/clever-avocados-punch.md deleted file mode 100644 index db4d52c577..0000000000 --- a/.changeset/clever-avocados-punch.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@evidence-dev/sdk': patch ---- - -fix virtual/references fields in datasource plugin schemas diff --git a/.changeset/cool-weeks-hang.md b/.changeset/cool-weeks-hang.md deleted file mode 100644 index 461c596cfc..0000000000 --- a/.changeset/cool-weeks-hang.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@evidence-dev/core-components': patch ---- - -fixed border regression in dateinput diff --git a/.changeset/five-bottles-worry.md b/.changeset/five-bottles-worry.md deleted file mode 100644 index f9053fd47c..0000000000 --- a/.changeset/five-bottles-worry.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@evidence-dev/universal-sql': patch ---- - -workaround bug in duckdb-wasm that errors when fully null date column is read as parquet diff --git a/.changeset/green-jeans-hide.md b/.changeset/green-jeans-hide.md deleted file mode 100644 index 909f647e04..0000000000 --- a/.changeset/green-jeans-hide.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@evidence-dev/evidence': patch ---- - -Add warning message to default index.md diff --git a/.changeset/sour-kings-move.md b/.changeset/sour-kings-move.md deleted file mode 100644 index 2c817b9cc6..0000000000 --- a/.changeset/sour-kings-move.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@evidence-dev/core-components': patch ---- - -Add third level pages to sidebar diff --git a/.changeset/twelve-toes-serve.md b/.changeset/twelve-toes-serve.md deleted file mode 100644 index 42684b0b20..0000000000 --- a/.changeset/twelve-toes-serve.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@evidence-dev/core-components': patch ---- - -Remove groupDataPopulated flag diff --git a/.changeset/wise-papayas-clap.md b/.changeset/wise-papayas-clap.md deleted file mode 100644 index d57af88a16..0000000000 --- a/.changeset/wise-papayas-clap.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@evidence-dev/core-components': patch ---- - -Styling changes for consistency diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index dc7db1c2bf..f0c1b83380 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -31,8 +31,14 @@ jobs: isMain: - ${{ github.base_ref == 'main' }} exclude: + - isMain: false + node-version: 18 - isMain: false node-version: 20 + - isMain: false + os: macOS-latest + - isMain: false + os: windows-latest name: e2e/${{ matrix.project }}/${{ matrix.os }}/node-${{ matrix.node-version}} runs-on: ${{ matrix.os }} diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 2dc43dd13e..6727a7be9b 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -22,8 +22,12 @@ jobs: isMain: - ${{ github.base_ref == 'main' }} exclude: + - isMain: false + node-version: 18 - isMain: false node-version: 20 + - isMain: false + os: macOS-latest steps: - run: git config --global core.autocrlf false diff --git a/.prettierignore b/.prettierignore index e32deddc46..8d5c67368a 100644 --- a/.prettierignore +++ b/.prettierignore @@ -20,7 +20,6 @@ yarn.lock /packages/components/* **/dist/* .changeset/* -vercel.json *.yaml /packages/ui/storybook-static/* diff --git a/e2e/hmr/tests/tests.spec.js b/e2e/hmr/tests/tests.spec.js index d19b538c59..5a231f7973 100644 --- a/e2e/hmr/tests/tests.spec.js +++ b/e2e/hmr/tests/tests.spec.js @@ -86,31 +86,3 @@ test.describe('error handling', () => { await expect(page.getByText('"new" cannot be used as a query name')).toBeVisible(); }); }); - -test.describe('page query HMR', () => { - test('editing should HMR', async ({ page }) => { - const query0 = 'select * from orders;'; - - await page.goto('/orders'); - // hard reload page for queries to SSR - await page.reload(); - - await waitForPageToLoad(page); - - await expect(page.getByText('Loaded 10000 orders')).toBeVisible(); - - const query1 = 'select * from orders LIMIT 500;'; - editFile('pages/orders.md', (content) => content.replace(query0, query1)); - await waitForHMR(page); - await expect(page.getByText('Loaded 500 orders')).toBeVisible(); - - const query2 = 'select * from orders LIMIT 100;'; - editFile('pages/orders.md', (content) => content.replace(query1, query2)); - await waitForHMR(page); - await expect(page.getByText('Loaded 100 orders')).toBeVisible(); - - editFile('pages/orders.md', (content) => content.replace(query2, query0)); - await waitForHMR(page); - await expect(page.getByText('Loaded 10000 orders')).toBeVisible(); - }); -}); diff --git a/packages/lib/preprocess/src/process-queries.cjs b/packages/lib/preprocess/src/process-queries.cjs index c3bb472538..0fd9527cd4 100644 --- a/packages/lib/preprocess/src/process-queries.cjs +++ b/packages/lib/preprocess/src/process-queries.cjs @@ -64,11 +64,6 @@ const createDefaultProps = function (filename, componentDevelopmentMode, duckdbQ return ` // Update external queries if (import.meta?.hot) { - import.meta.hot.on("vite:beforeUpdate", () => { - // remove all prerendered queries - delete props.data; - }); - import.meta.hot.on("evidence:queryChange", ({queryId, content}) => { let errors = [] if (!queryId) errors.push("Malformed event: Missing queryId") diff --git a/packages/lib/sdk/src/plugins/datasources/cli/edit/Options.js b/packages/lib/sdk/src/plugins/datasources/cli/edit/Options.js index 4f5c72a86d..7b3325440a 100644 --- a/packages/lib/sdk/src/plugins/datasources/cli/edit/Options.js +++ b/packages/lib/sdk/src/plugins/datasources/cli/edit/Options.js @@ -68,7 +68,6 @@ export const Options = (spec, sourceOptions, opts) => { ownKeys() { const output = []; for (const [specKey, specEntry] of Object.entries(spec)) { - if (specEntry.virtual) continue; const valueKey = specEntry.children && specEntry.nest ? `_${specKey}` : specKey; if ( !opts?.specMode /* Value Mode */ && diff --git a/packages/lib/sdk/src/plugins/datasources/cli/edit/Options.spec.js b/packages/lib/sdk/src/plugins/datasources/cli/edit/Options.spec.js index 770eb32f2f..cc21de1cf1 100644 --- a/packages/lib/sdk/src/plugins/datasources/cli/edit/Options.spec.js +++ b/packages/lib/sdk/src/plugins/datasources/cli/edit/Options.spec.js @@ -59,103 +59,6 @@ const testSpec = { } }; -const complexSpec = { - project_id: { - title: 'Project ID', - type: 'string', - secret: true, - virtual: false, - references: '$.keyfile.project_id', - forceReference: false, - required: true - }, - location: { - title: 'Location (Region)', - type: 'string', - secret: false, - virtual: false, - forceReference: false, - required: false, - default: 'US' - }, - authenticator: { - title: 'Authentication Method', - type: 'select', - secret: false, - virtual: false, - forceReference: false, - children: { - 'service-account': { - keyfile: { - title: 'Credentials File', - type: 'file', - secret: false, - virtual: true, - forceReference: false, - fileFormat: 'json', - required: false - }, - client_email: { - title: 'Client Email', - type: 'string', - secret: true, - virtual: false, - references: '$.keyfile.client_email', - forceReference: true, - required: true - }, - private_key: { - title: 'Private Key', - type: 'string', - secret: true, - virtual: false, - references: '$.keyfile.private_key', - forceReference: true, - required: true - } - }, - 'gcloud-cli': {}, - oauth: { - token: { - title: 'Token', - type: 'string', - secret: true, - virtual: false, - forceReference: false, - required: true - } - } - }, - required: true, - options: [ - { value: 'service-account', label: 'Service Account' }, - { value: 'gcloud-cli', label: 'GCloud CLI' }, - { value: 'oauth', label: 'OAuth Access Token' } - ], - nest: false, - default: 'service-account' - } -}; -const complexOpts = { - location: 'US', - authenticator: 'service-account', - project_id: 'deadbeef-project', - keyfile: { - type: 'service_account', - project_id: 'deadbeef-project', - private_key_id: 'deadbeef', - private_key: 'my private key', - client_email: 'client@email.com', - client_id: '42', - auth_uri: 'https://evidence.dev', - token_uri: 'https://evidence.dev', - auth_provider_x509_cert_url: 'https://evidence.dev', - client_x509_cert_url: 'https://evidence.dev' - }, - client_email: 'https://evidence.dev', - private_key: 'my private key' -}; - describe('Options', () => { describe('get', () => { describe('root-level', () => { @@ -391,18 +294,6 @@ describe('getSecretOptions', () => { expect(secrets.unnested).toBeUndefined(); expect(secrets).toEqual({ _secret: 'Hi!' }); }); - - it('should ignore virtual fields', () => { - const options = Options(complexSpec, complexOpts); - - const secrets = getSecretOptions(options); - - expect(secrets).toEqual({ - client_email: 'https://evidence.dev', - private_key: 'my private key', - project_id: 'deadbeef-project' - }); - }); }); describe('getSafeOptions', () => { it('should return safe values', () => { @@ -450,14 +341,6 @@ describe('getSafeOptions', () => { expect(safes.unnested).toEqual('a'); expect(safes).toEqual({ _opt: 'Bye!', unnested: 'a' }); }); - - it('should ignore virtual fields', () => { - const options = Options(complexSpec, complexOpts); - - const safes = getSafeOptions(options); - - expect(safes).toEqual({ authenticator: 'service-account', location: 'US' }); - }); }); describe('getSpecAtPath', () => { diff --git a/packages/lib/universal-sql/src/build-parquet.js b/packages/lib/universal-sql/src/build-parquet.js index 42dd46709a..fcff5bc5fe 100644 --- a/packages/lib/universal-sql/src/build-parquet.js +++ b/packages/lib/universal-sql/src/build-parquet.js @@ -34,17 +34,6 @@ function convertArrayToVector(column, rawValues) { case 'string': return vectorFromArray(rawValues, new Utf8()); case 'date': - if (!rawValues.some((v) => v !== null)) { - // All null date columns error out, so we have to do this - // https://github.com/evidence-dev/evidence/issues/2897 - // separate reason than the bool version - console.warn( - chalk.yellow( - `\nWarning: Column "${column.name}" (type Date) contains only null values so it has been cast to Float64` - ) - ); - return vectorFromArray(rawValues, new Float64()); - } // TODO: What gives with timezones return vectorFromArray(rawValues, new TimestampMillisecond()); case 'boolean': diff --git a/packages/ui/core-components/src/lib/atoms/inputs/button-group/ButtonGroup.svelte b/packages/ui/core-components/src/lib/atoms/inputs/button-group/ButtonGroup.svelte index 4862231392..638fa8cb64 100644 --- a/packages/ui/core-components/src/lib/atoms/inputs/button-group/ButtonGroup.svelte +++ b/packages/ui/core-components/src/lib/atoms/inputs/button-group/ButtonGroup.svelte @@ -102,17 +102,15 @@ {:else}
{#if title} - {title} + {title} {/if}
{#if preset} diff --git a/packages/ui/core-components/src/lib/atoms/inputs/checkbox/Checkbox.svelte b/packages/ui/core-components/src/lib/atoms/inputs/checkbox/Checkbox.svelte index c81f46bc4d..f6061c6e94 100644 --- a/packages/ui/core-components/src/lib/atoms/inputs/checkbox/Checkbox.svelte +++ b/packages/ui/core-components/src/lib/atoms/inputs/checkbox/Checkbox.svelte @@ -34,7 +34,7 @@ on:click={() => ($inputs[name] = !$inputs[name])} variant="outline" size="sm" - class="min-w-40 inline-flex justify-between gap-4 items-center w-full max-w-fit mb-4 mr-2" + class="min-w-40 inline-flex justify-between gap-4 items-center w-full max-w-fit mb-2" >

{title} diff --git a/packages/ui/core-components/src/lib/atoms/inputs/date-input/_DateInput.svelte b/packages/ui/core-components/src/lib/atoms/inputs/date-input/_DateInput.svelte index 8a480d691c..f1bb935a8c 100644 --- a/packages/ui/core-components/src/lib/atoms/inputs/date-input/_DateInput.svelte +++ b/packages/ui/core-components/src/lib/atoms/inputs/date-input/_DateInput.svelte @@ -232,7 +232,7 @@ variant="outline" size="sm" class={cn( - `flex justify-start ${range ? 'border-r-0 rounded-r-none text-left' : 'text-center'} font-normal`, + `flex justify-start ${range ? 'border-r rounded-r-none text-left' : 'text-center'} font-normal`, !selectedDateInput && 'text-base-content-muted' )} builders={[builder]} diff --git a/packages/ui/core-components/src/lib/atoms/inputs/date-range/DateRange.svelte b/packages/ui/core-components/src/lib/atoms/inputs/date-range/DateRange.svelte index 281cc4b2ff..e550ba95af 100644 --- a/packages/ui/core-components/src/lib/atoms/inputs/date-range/DateRange.svelte +++ b/packages/ui/core-components/src/lib/atoms/inputs/date-range/DateRange.svelte @@ -63,9 +63,9 @@ -

+
{#if title} - {title} + {title} {/if} {#if $query?.error} diff --git a/packages/ui/core-components/src/lib/atoms/inputs/dropdown/Dropdown.svelte b/packages/ui/core-components/src/lib/atoms/inputs/dropdown/Dropdown.svelte index 31f428c2a3..43b91ed451 100644 --- a/packages/ui/core-components/src/lib/atoms/inputs/dropdown/Dropdown.svelte +++ b/packages/ui/core-components/src/lib/atoms/inputs/dropdown/Dropdown.svelte @@ -209,7 +209,7 @@ {/each} -
+
{#if hasQuery && $query.error}

- {title}: - - {fmt ? formatValue($inputs[name], format_object) : $inputs[name]} + {title} : + {fmt ? formatValue($inputs[name], format_object) : $inputs[name]}

{#if showMaxMin} diff --git a/packages/ui/core-components/src/lib/atoms/inputs/text/TextInput.svelte b/packages/ui/core-components/src/lib/atoms/inputs/text/TextInput.svelte index c7f85f365f..89d95c6724 100644 --- a/packages/ui/core-components/src/lib/atoms/inputs/text/TextInput.svelte +++ b/packages/ui/core-components/src/lib/atoms/inputs/text/TextInput.svelte @@ -58,13 +58,13 @@ -
+
{#if title} - {title} + {title} {/if}
diff --git a/packages/ui/core-components/src/lib/molecules/dimension-grid/DimensionCut.svelte b/packages/ui/core-components/src/lib/molecules/dimension-grid/DimensionCut.svelte index cd970db7e7..1ea1f3f86f 100644 --- a/packages/ui/core-components/src/lib/molecules/dimension-grid/DimensionCut.svelte +++ b/packages/ui/core-components/src/lib/molecules/dimension-grid/DimensionCut.svelte @@ -111,16 +111,14 @@ -
+
- + {formatTitle(dimension.column_name)} - {#if metricLabel} - - {metricLabel ?? ''} - - {/if} + + {metricLabel ?? ''} +
diff --git a/packages/ui/core-components/src/lib/molecules/dimension-grid/DimensionRow.svelte b/packages/ui/core-components/src/lib/molecules/dimension-grid/DimensionRow.svelte index e3f66c5e2d..9c1b720803 100644 --- a/packages/ui/core-components/src/lib/molecules/dimension-grid/DimensionRow.svelte +++ b/packages/ui/core-components/src/lib/molecules/dimension-grid/DimensionRow.svelte @@ -14,7 +14,7 @@
{row.dimensionValue ?? 'Missing'} - + {#if row.metric} {formattedValue} {:else} diff --git a/packages/ui/core-components/src/lib/organisms/layout/EvidenceDefaultLayout.svelte b/packages/ui/core-components/src/lib/organisms/layout/EvidenceDefaultLayout.svelte index 14c4aa806e..f1b3c42135 100644 --- a/packages/ui/core-components/src/lib/organisms/layout/EvidenceDefaultLayout.svelte +++ b/packages/ui/core-components/src/lib/organisms/layout/EvidenceDefaultLayout.svelte @@ -59,8 +59,6 @@ export let hideHeader = false; /** @type {boolean} */ export let hideTOC = false; - /** @type {number} */ - export let sidebarDepth = 3; const prefetchStrategy = dev ? 'tap' : 'hover'; @@ -173,7 +171,6 @@ {builtWithEvidence} {hideHeader} {sidebarFrontMatter} - {sidebarDepth} />
{/if} diff --git a/packages/ui/core-components/src/lib/organisms/layout/sidebar/Sidebar.svelte b/packages/ui/core-components/src/lib/organisms/layout/sidebar/Sidebar.svelte index cc7afb6e6d..a16af1cfee 100644 --- a/packages/ui/core-components/src/lib/organisms/layout/sidebar/Sidebar.svelte +++ b/packages/ui/core-components/src/lib/organisms/layout/sidebar/Sidebar.svelte @@ -1,9 +1,7 @@ - Next: Deep Dive on Metrics → + Best Website Ever diff --git a/packages/ui/core-components/src/lib/unsorted/ui/BigLink.svelte b/packages/ui/core-components/src/lib/unsorted/ui/BigLink.svelte index b7553fec4c..51d0ddefce 100644 --- a/packages/ui/core-components/src/lib/unsorted/ui/BigLink.svelte +++ b/packages/ui/core-components/src/lib/unsorted/ui/BigLink.svelte @@ -4,22 +4,37 @@ -
- -
- - - -
- -
+ +
+ + + +
+ + + diff --git a/packages/ui/core-components/src/lib/unsorted/ui/LinkButton.stories.svelte b/packages/ui/core-components/src/lib/unsorted/ui/LinkButton.stories.svelte index 033074f373..473451daf5 100644 --- a/packages/ui/core-components/src/lib/unsorted/ui/LinkButton.stories.svelte +++ b/packages/ui/core-components/src/lib/unsorted/ui/LinkButton.stories.svelte @@ -13,5 +13,4 @@ Best Website Ever - Best Website Ever diff --git a/packages/ui/core-components/src/lib/unsorted/ui/LinkButton.svelte b/packages/ui/core-components/src/lib/unsorted/ui/LinkButton.svelte index 51b602b558..6c7587a439 100644 --- a/packages/ui/core-components/src/lib/unsorted/ui/LinkButton.svelte +++ b/packages/ui/core-components/src/lib/unsorted/ui/LinkButton.svelte @@ -7,18 +7,13 @@ export let url; -
- -
- - - -
- -
+ +
+ + + +
+ diff --git a/packages/ui/core-components/src/lib/unsorted/ui/Modal.stories.svelte b/packages/ui/core-components/src/lib/unsorted/ui/Modal.stories.svelte deleted file mode 100644 index e53abed853..0000000000 --- a/packages/ui/core-components/src/lib/unsorted/ui/Modal.stories.svelte +++ /dev/null @@ -1,24 +0,0 @@ - - - - - - Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut - labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco - laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in - voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat - non proident, sunt in culpa qui officia deserunt mollit anim id est laborum. Lorem ipsum dolor - sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore - magna aliqua. - diff --git a/packages/ui/core-components/src/lib/unsorted/ui/Modal.svelte b/packages/ui/core-components/src/lib/unsorted/ui/Modal.svelte index ebb2cec439..7920525753 100644 --- a/packages/ui/core-components/src/lib/unsorted/ui/Modal.svelte +++ b/packages/ui/core-components/src/lib/unsorted/ui/Modal.svelte @@ -7,61 +7,40 @@ import { Icon } from '@steeze-ui/svelte-icon'; import { createEventDispatcher } from 'svelte'; const dispatch = createEventDispatcher(); - export let open = false; export let title = ''; export let buttonText = ''; export let innerText = ''; - - let closing = false; - const isOpen = () => { - if (open) { - closing = true; - setTimeout(() => { - closing = false; - open = false; - dispatch('close'); - }, 150); // Set duration to slightly shorter than exit animation - } else { - open = true; - } + open = !open; + if (!open) dispatch('close'); }; -
- -
-{#if open || closing} -
+ +{#if open} +
{#if title.trim() != ''} {title} {/if} {#if title.trim() == ''} @@ -69,14 +48,14 @@ class="flex items-center justify-center border-none p-0.5 absolute right-0 top-0 ml-4" on:click={() => isOpen()} > - + {/if}
{innerText} @@ -84,43 +63,3 @@
{/if} - - diff --git a/packages/ui/core-components/src/lib/unsorted/viz/core/SearchBar.svelte b/packages/ui/core-components/src/lib/unsorted/viz/core/SearchBar.svelte index cb798efecc..45d5825ad0 100644 --- a/packages/ui/core-components/src/lib/unsorted/viz/core/SearchBar.svelte +++ b/packages/ui/core-components/src/lib/unsorted/viz/core/SearchBar.svelte @@ -26,17 +26,18 @@