[Bug]: Cannot use spaces in markdown page names

[archiewood]

Describe the bug

Upgraded from 39.1.13 of evidence in my local development environment and recently tried to upgrade to version 40.0.1.

Markdown pages that contain special characters now break eg white space.md

Steps to Reproduce

Add a page with a space eg page two.md and try to navigate to it from the sidebar

CleanShot.2024-12-23.at.09.47.10.mp4

it's detecting the pre encoded space character %20 and then encoding it again, replacing the %-> %25
so overall you get page two.md -> page%20two -> page%2520two

Logs

System Info

System:
    OS: macOS 14.2.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 990.44 MB / 16.00 GB
    Shell: 5.1.16 - /opt/homebrew/bin/bash
  Binaries:
    Node: 22.11.0 - ~/.nvm/versions/node/v22.11.0/bin/node
    npm: 10.9.0 - ~/.nvm/versions/node/v22.11.0/bin/npm
    pnpm: 8.6.9 - /opt/homebrew/bin/pnpm
    bun: 1.0.25 - /opt/homebrew/bin/bun
  Browsers:
    Brave Browser: 123.1.64.122
    Chrome: 131.0.6778.205
    Safari: 17.2.1
  npmPackages:
    @evidence-dev/bigquery: ^2.0.9 => 2.0.9 
    @evidence-dev/core-components: ^5.0.3 => 5.0.3 
    @evidence-dev/csv: ^1.0.14 => 1.0.14 
    @evidence-dev/databricks: ^1.0.8 => 1.0.8 
    @evidence-dev/duckdb: ^1.0.13 => 1.0.13 
    @evidence-dev/evidence: ^40.0.3 => 40.0.3 
    @evidence-dev/motherduck: ^1.0.4 => 1.0.4 
    @evidence-dev/mssql: ^1.1.2 => 1.1.2 
    @evidence-dev/mysql: ^1.1.4 => 1.1.4 
    @evidence-dev/postgres: ^1.0.7 => 1.0.7 
    @evidence-dev/snowflake: ^1.2.2 => 1.2.2 
    @evidence-dev/sqlite: ^2.0.7 => 2.0.7 
    @evidence-dev/trino: ^1.0.9 => 1.0.9

Severity

serious, but I can work around it

Additional Information, or Workarounds

Workaround is to not use spaces / special characters in app paths

[yecnj]

Hello.

I am yeonj, who first reported this issue on Slack.
I am excited to be involved in opening this issue.

Although I have limited experience contributing to open source, I am very interested in personally resolving the issues I report.
If given the opportunity, I would like to attempt to resolve this issue with a PR.

[archiewood]

You are welcome to take a look at it. I'd suggest looking in Sidebar.svelte to begin with.

https://github.com/evidence-dev/evidence/blob/next/packages/ui/core-components/src/lib/organisms/layout/sidebar/Sidebar.svelte

[yecnj]

Thank you for guiding me to the starting point! I'll start by reviewing the file.