Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout and frontmatter adjustments #2948

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

Layout and frontmatter adjustments #2948

wants to merge 4 commits into from
+83 −28

Conversation

hughess
Copy link
Member

@hughess hughess commented Dec 20, 2024 •
edited
Loading

Description

  • Adjusts alignment of mobile hamburger menu to get as close to edge of content as possible
  • Fixes spacing of page contents when using sidebar option in frontmatter
  • Adds new options to page frontmatter to better align with layout options and give you control of page-specific layout:
    • hide_header
    • hide_toc
    • hide_breadcrumbs
    • full_width
    • max_width
  • Fixes frontmatter in templated pages - closes [Bug]: sidebar: hide in frontmatter does not work on templated pages #2859

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable

@archiewood
Copy link
Member

Worth checking the behaviour of these on templated pages as they are tricker!

@hughess
Copy link
Member Author

hughess commented Dec 27, 2024

@archiewood it turns out the frontmatter wasn't being read from templated pages because of the URL format. I've added a fix in here that makes it work for templated pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: sidebar: hide in frontmatter does not work on templated pages
2 participants
@hughess @archiewood