Use scraped #9
Open
Use scraped #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 7, 2017 10:35
This class represents a document listing members of the legislature.
added 6 commits
July 7, 2017 10:44
The scraper now conforms to rubocop.
TODO: The member has multiple phone numbers recorded without a delimiter: everypolitician/everypolitician-data#33726
Instead of recording the url of the member's portrait, the scraper is getting the URL of a PDF icon. Issue: everypolitician/everypolitician-data#33716
ondenman
force-pushed
the
use-scraped
branch
2 times, most recently
from
51d4cab
to
e66515f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in preparation of making further fixes:
Fix the image field so the correct image is captured for all members (everypolitician/everypolitician-data#33716)
Split multiple phone numbers and emails (everypolitician/everypolitician-data#33726)