Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

Feature request: add station IDs to evelink.parsing.assets.parse_assets results #127

Open
dinoboff opened this issue Feb 6, 2013 · 4 comments

Comments

@dinoboff
Copy link
Contributor

dinoboff commented Feb 6, 2013

When an asset is in station, the location ID can be converted to a station ID:

http://wiki.eve-id.net/APIv2_Corp_AssetList_XML

evelink.parsing.assets.parse_assets could do the conversion and add a station key to every item result in station. It would be a dict holding the station id and a boolean indicating if the station is NPC (with all attributes in the static data dump) or conquerable (listed at eve/ConquerableStationList.xml.aspx).

It would be up to the user to query the correct data source to get the station name or owner.

@ayust
Copy link
Member

ayust commented Oct 31, 2014

@regner Would it be possible to introduce a cleaner way to do this kind of conversion (e.g. have it done as part of the asset APIs themselves)? I don't really like having magic number constants hanging around in 3rd party code.

@regner
Copy link
Contributor

regner commented Nov 1, 2014

I will attempt to see if there is something I can do, but don't have high
hopes.

Regner Blok-Andersen
http://highguard.net/

On Fri, Oct 31, 2014 at 6:39 PM, Amber Yust [email protected]
wrote:

@regner https://github.com/Regner Would it be possible to introduce a
cleaner way to do this kind of conversion (e.g. have it done as part of the
asset APIs themselves)?


Reply to this email directly or view it on GitHub
#127 (comment).

@ayust
Copy link
Member

ayust commented Nov 1, 2014

No worries. Seems like more of a "nice to have" than anything critical.

@ayust
Copy link
Member

ayust commented Nov 23, 2014

I still don't really like the idea of having magic number conversion going on in the default return objects. Perhaps this might be a candidate for a utility function included in evelink/thirdparty or some such? Then people who want to do that conversion can do it easily, but if it ever breaks we're not on the hook for providing bad data.

@ayust ayust changed the title Add station IDs to evelink.parsing.assets.parse_assets results Feature request: add station IDs to evelink.parsing.assets.parse_assets results Oct 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants