Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function.AssertEquals for shapes #528

Open
gertjanvanzwieten opened this issue Apr 16, 2020 · 0 comments
Open

add function.AssertEquals for shapes #528

gertjanvanzwieten opened this issue Apr 16, 2020 · 0 comments

Comments

@gertjanvanzwieten
Copy link
Contributor

Currently operations with more than a single argument must have identical shapes, including when shapes contain functions. The problem with that is that functions have no canonical form (even though an attempt is made using simplify) so that check is too strict. A solution would be to introduce an AssertEquals operation that evaluates both, asserts equality, and returns the result. Its simplify operation can do what is done currently: simplify the arguments and return one if it matches the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant