Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make interface topologies their own class #387

Open
gertjanvanzwieten opened this issue Jan 11, 2019 · 0 comments
Open

make interface topologies their own class #387

gertjanvanzwieten opened this issue Jan 11, 2019 · 0 comments

Comments

@gertjanvanzwieten
Copy link
Contributor

Currently all topologies define both transforms and opposites. If a topology is not an interface then opposites are set to equal transforms. In this situation it would be better to not define them at all so that evaluation of function.opposite fails, pointing out a mistake in the formulation.
Suggestion: let's remove 'opposites' from Topology, and introduce a new InterfaceTopology that depends on a reference sequence and two transform sequences. It will lack connectivity, which is already the case for most interfaces and should not be an issue in typical applications. The StructuredTopology may still supply its own (structured) boundaries with opposites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant