From cbb8e75977f77cf1e804b479d253ba8d91a511ff Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Wed, 27 Mar 2024 14:43:04 -0400 Subject: [PATCH 01/17] Add blui-ci github action --- .circleci/config.yml | 179 ---------------------------------- .github/workflows/blui-ci.yml | 90 +++++++++++++++++ 2 files changed, 90 insertions(+), 179 deletions(-) delete mode 100644 .circleci/config.yml create mode 100644 .github/workflows/blui-ci.yml diff --git a/.circleci/config.yml b/.circleci/config.yml deleted file mode 100644 index 8da53617..00000000 --- a/.circleci/config.yml +++ /dev/null @@ -1,179 +0,0 @@ -version: 2.1 -orbs: - codecov: codecov/codecov@3.2.2 - gh: circleci/github-cli@2.2.0 - browser-tools: circleci/browser-tools@1.4.8 - -jobs: - install_dependencies: - docker: - - image: cimg/node:18.17.0-browsers - working_directory: ~/login-workflow - resource_class: large - steps: - - checkout - - restore_cache: - keys: - - v2-dependencies-{{ checksum "login-workflow/yarn.lock" }} - - run: - name: Install Dependencies - command: | - cd login-workflow - yarn install --frozen-lockfile - - save_cache: - name: Save Cache - paths: - - node_modules - key: v2-dependencies-{{ checksum "login-workflow/yarn.lock" }} - - prettier_check: - docker: - - image: cimg/node:18.17.0-browsers - working_directory: ~/login-workflow - resource_class: large - steps: - - checkout - - restore_cache: - keys: - - v2-dependencies-{{ checksum "login-workflow/yarn.lock" }} - - run: - name: Install Dependencies - command: | - cd login-workflow - yarn install --frozen-lockfile - - run: - name: Prettier Check - command: | - cd login-workflow - yarn prettier:check - - lint_check: - docker: - - image: cimg/node:18.17.0-browsers - environment: - NODE_OPTIONS=--max-old-space-size=5120 - working_directory: ~/login-workflow - resource_class: large - steps: - - checkout - - restore_cache: - keys: - - v2-dependencies-{{ checksum "login-workflow/yarn.lock" }} - - run: - name: Install Dependencies - command: | - cd login-workflow - yarn install --frozen-lockfile - - run: - name: Lint - command: | - cd login-workflow - yarn lint - - store_test_results: - docker: - - image: cimg/node:18.17.0-browsers - parallelism: 4 - working_directory: ~/login-workflow - resource_class: large - steps: - - checkout - - restore_cache: - keys: - - v2-dependencies-{{ checksum "login-workflow/yarn.lock" }} - - run: - name: Install Dependencies - command: | - cd login-workflow - yarn install --frozen-lockfile - - run: - name: Tests - command: | - cd login-workflow - yarn test:ci --maxWorkers=2 --coverage --watchAll=false - - persist_to_workspace: - root: . - paths: - - login-workflow/coverage - - build_login_workflow: - docker: - - image: cimg/node:18.17.0-browsers - environment: - NODE_OPTIONS=--max-old-space-size=5120 - working_directory: ~/login-workflow - resource_class: large - steps: - - checkout - - restore_cache: - keys: - - v2-dependencies-{{ checksum "login-workflow/yarn.lock" }} - - run: - name: Install Dependencies - command: | - cd login-workflow - yarn install --frozen-lockfile - - run: - name: Build - command: | - cd login-workflow - yarn build - - persist_to_workspace: - root: . - paths: - - login-workflow/dist - - coverage_report: - working_directory: ~/login-workflow - docker: - - image: cimg/node:18.17.0-browsers - steps: - - checkout - - attach_workspace: - at: . - - codecov/upload: - file: './login-workflow/coverage/clover.xml' - flags: unit_tests - token: CODECOV_TOKEN - - publish_login_workflow: - docker: - - image: cimg/node:18.17.0-browsers - steps: - - checkout - - attach_workspace: - at: . - - run: - name: Authenticate with registry - command: | - echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" > ~/.npmrc - echo "//registry.yarnpkg.com/:_authToken=$NPM_TOKEN" >> ~/.npmrc - - run: - name: Publish @brightlayer-ui/react-auth-workflow - command: | - cd login-workflow && yarn publish:package -b $CIRCLE_BRANCH - -workflows: - react_workflows: - jobs: - - install_dependencies - - prettier_check - - lint_check - - store_test_results - - build_login_workflow - - publish_login_workflow: - requires: - - build_login_workflow - filters: - branches: - only: - - master - - dev - - coverage_report: - requires: - - store_test_results - filters: - branches: - only: - - master - - dev diff --git a/.github/workflows/blui-ci.yml b/.github/workflows/blui-ci.yml new file mode 100644 index 00000000..9ce4967a --- /dev/null +++ b/.github/workflows/blui-ci.yml @@ -0,0 +1,90 @@ +name: CI Run + +on: + push: + branches: [ "dev", "master" ] + pull_request: + branches: [ "dev", "master" ] + pull_request_target: + types: + - opened + branches: + - '*/*' + +permissions: + pull-requests: write + contents: read + +jobs: + prettier_lint: + runs-on: ubuntu-latest + + strategy: + matrix: + node-version: [18.x] + + steps: + - uses: actions/checkout@v4 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node-version }} + cache: 'yarn' + - run: yarn --frozen-lockfile + working-directory: login-workflow + - run: yarn prettier + working-directory: login-workflow + - run: yarn lint + working-directory: login-workflow + + unit_test: + runs-on: ubuntu-latest + + strategy: + matrix: + node-version: [18.x] + + steps: + - uses: actions/checkout@v4 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node-version }} + cache: 'yarn' + - run: yarn --frozen-lockfile + working-directory: login-workflow + - run: yarn test:ci --coverage --watchAll=false + working-directory: login-workflow + - name: Upload to Codecov + uses: codecov/codecov-action@v3 + with: + directory: ./coverage/ + files: clover.xml + flags: unittests + name: codecov-report + verbose: true + + build: + runs-on: ubuntu-latest + + strategy: + matrix: + node-version: [18.x] + + steps: + - uses: actions/checkout@v4 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node-version }} + cache: 'yarn' + - run: yarn --frozen-lockfile + working-directory: login-workflow + - run: yarn build + working-directory: login-workflow + - name: Save build + uses: actions/upload-artifact@v3 + with: + name: dist + if-no-files-found: error + path: dist \ No newline at end of file From 2f6ce92a76104af6d3ff655402e6a2856019e25d Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Wed, 27 Mar 2024 14:48:50 -0400 Subject: [PATCH 02/17] try path to dir --- .github/workflows/blui-ci.yml | 98 +++++++++++++++++------------------ 1 file changed, 49 insertions(+), 49 deletions(-) diff --git a/.github/workflows/blui-ci.yml b/.github/workflows/blui-ci.yml index 9ce4967a..abdd72fa 100644 --- a/.github/workflows/blui-ci.yml +++ b/.github/workflows/blui-ci.yml @@ -31,60 +31,60 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'yarn' - run: yarn --frozen-lockfile - working-directory: login-workflow + working-directory: blui-react-workflows/login-workflow - run: yarn prettier - working-directory: login-workflow + working-directory: blui-react-workflows/login-workflow - run: yarn lint - working-directory: login-workflow + working-directory: blui-react-workflows/login-workflow - unit_test: - runs-on: ubuntu-latest + # unit_test: + # runs-on: ubuntu-latest - strategy: - matrix: - node-version: [18.x] + # strategy: + # matrix: + # node-version: [18.x] - steps: - - uses: actions/checkout@v4 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v4 - with: - node-version: ${{ matrix.node-version }} - cache: 'yarn' - - run: yarn --frozen-lockfile - working-directory: login-workflow - - run: yarn test:ci --coverage --watchAll=false - working-directory: login-workflow - - name: Upload to Codecov - uses: codecov/codecov-action@v3 - with: - directory: ./coverage/ - files: clover.xml - flags: unittests - name: codecov-report - verbose: true + # steps: + # - uses: actions/checkout@v4 + # - name: Use Node.js ${{ matrix.node-version }} + # uses: actions/setup-node@v4 + # with: + # node-version: ${{ matrix.node-version }} + # cache: 'yarn' + # - run: yarn --frozen-lockfile + # working-directory: login-workflow + # - run: yarn test:ci --coverage --watchAll=false + # working-directory: login-workflow + # - name: Upload to Codecov + # uses: codecov/codecov-action@v3 + # with: + # directory: ./coverage/ + # files: clover.xml + # flags: unittests + # name: codecov-report + # verbose: true - build: - runs-on: ubuntu-latest + # build: + # runs-on: ubuntu-latest - strategy: - matrix: - node-version: [18.x] + # strategy: + # matrix: + # node-version: [18.x] - steps: - - uses: actions/checkout@v4 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v4 - with: - node-version: ${{ matrix.node-version }} - cache: 'yarn' - - run: yarn --frozen-lockfile - working-directory: login-workflow - - run: yarn build - working-directory: login-workflow - - name: Save build - uses: actions/upload-artifact@v3 - with: - name: dist - if-no-files-found: error - path: dist \ No newline at end of file + # steps: + # - uses: actions/checkout@v4 + # - name: Use Node.js ${{ matrix.node-version }} + # uses: actions/setup-node@v4 + # with: + # node-version: ${{ matrix.node-version }} + # cache: 'yarn' + # - run: yarn --frozen-lockfile + # working-directory: login-workflow + # - run: yarn build + # working-directory: login-workflow + # - name: Save build + # uses: actions/upload-artifact@v3 + # with: + # name: dist + # if-no-files-found: error + # path: dist \ No newline at end of file From 08c5fd75f8f3f6daf0e0a36321427beadccfbd07 Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Wed, 27 Mar 2024 14:51:57 -0400 Subject: [PATCH 03/17] set path --- .github/workflows/blui-ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/blui-ci.yml b/.github/workflows/blui-ci.yml index abdd72fa..5412fbd0 100644 --- a/.github/workflows/blui-ci.yml +++ b/.github/workflows/blui-ci.yml @@ -31,11 +31,11 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'yarn' - run: yarn --frozen-lockfile - working-directory: blui-react-workflows/login-workflow + working-directory: ./login-workflow - run: yarn prettier - working-directory: blui-react-workflows/login-workflow + working-directory: ./login-workflow - run: yarn lint - working-directory: blui-react-workflows/login-workflow + working-directory: ./login-workflow # unit_test: # runs-on: ubuntu-latest From c98204665f9be4e979ad959780dbd5c064d9b757 Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Wed, 27 Mar 2024 14:59:10 -0400 Subject: [PATCH 04/17] update checkout --- .github/workflows/blui-ci.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/blui-ci.yml b/.github/workflows/blui-ci.yml index 5412fbd0..309b2f9a 100644 --- a/.github/workflows/blui-ci.yml +++ b/.github/workflows/blui-ci.yml @@ -24,18 +24,19 @@ jobs: node-version: [18.x] steps: - - uses: actions/checkout@v4 + - name: Checkout + uses: actions/checkout@v4 - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} cache: 'yarn' - run: yarn --frozen-lockfile - working-directory: ./login-workflow + working-directory: login-workflow - run: yarn prettier - working-directory: ./login-workflow + working-directory: login-workflow - run: yarn lint - working-directory: ./login-workflow + working-directory: login-workflow # unit_test: # runs-on: ubuntu-latest From 304fe21542e71761c0451ad1ff6a110c89e1a8ef Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Wed, 27 Mar 2024 15:00:47 -0400 Subject: [PATCH 05/17] install all --- .github/workflows/blui-ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/blui-ci.yml b/.github/workflows/blui-ci.yml index 309b2f9a..425c49c6 100644 --- a/.github/workflows/blui-ci.yml +++ b/.github/workflows/blui-ci.yml @@ -31,8 +31,7 @@ jobs: with: node-version: ${{ matrix.node-version }} cache: 'yarn' - - run: yarn --frozen-lockfile - working-directory: login-workflow + - run: yarn install:dependencies - run: yarn prettier working-directory: login-workflow - run: yarn lint From c65a6fb52b7339462d99a8b18cbe46024204e22c Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Wed, 27 Mar 2024 15:02:11 -0400 Subject: [PATCH 06/17] install --- .github/workflows/blui-ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/blui-ci.yml b/.github/workflows/blui-ci.yml index 425c49c6..c0d08501 100644 --- a/.github/workflows/blui-ci.yml +++ b/.github/workflows/blui-ci.yml @@ -32,10 +32,10 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'yarn' - run: yarn install:dependencies - - run: yarn prettier - working-directory: login-workflow - - run: yarn lint - working-directory: login-workflow + # - run: yarn prettier + # working-directory: login-workflow + # - run: yarn lint + # working-directory: login-workflow # unit_test: # runs-on: ubuntu-latest From 38774e90f022efb664337e2b1a1abdf1f064fbc8 Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Wed, 27 Mar 2024 15:03:35 -0400 Subject: [PATCH 07/17] install --- .github/workflows/blui-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/blui-ci.yml b/.github/workflows/blui-ci.yml index c0d08501..ef177b37 100644 --- a/.github/workflows/blui-ci.yml +++ b/.github/workflows/blui-ci.yml @@ -32,6 +32,7 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'yarn' - run: yarn install:dependencies + working-directory: login-workflow # - run: yarn prettier # working-directory: login-workflow # - run: yarn lint From e1270c5fa5238cf0bf841af7b3a500d6e73e94fe Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Wed, 27 Mar 2024 15:11:18 -0400 Subject: [PATCH 08/17] path again --- .github/workflows/blui-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/blui-ci.yml b/.github/workflows/blui-ci.yml index ef177b37..c2fa1f5b 100644 --- a/.github/workflows/blui-ci.yml +++ b/.github/workflows/blui-ci.yml @@ -32,7 +32,7 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'yarn' - run: yarn install:dependencies - working-directory: login-workflow + working-directory: ./login-workflow # - run: yarn prettier # working-directory: login-workflow # - run: yarn lint From a46db71c8688c7c81968b3c604221d4c44c1c803 Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Wed, 27 Mar 2024 15:17:23 -0400 Subject: [PATCH 09/17] cache dep path --- .github/workflows/blui-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/blui-ci.yml b/.github/workflows/blui-ci.yml index c2fa1f5b..6707248f 100644 --- a/.github/workflows/blui-ci.yml +++ b/.github/workflows/blui-ci.yml @@ -31,8 +31,9 @@ jobs: with: node-version: ${{ matrix.node-version }} cache: 'yarn' + cache-dependency-path: login-workflow - run: yarn install:dependencies - working-directory: ./login-workflow + working-directory: login-workflow # - run: yarn prettier # working-directory: login-workflow # - run: yarn lint From f1d2f6f9c36a545bb0c5ac27358e6703ba9fa7a2 Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Wed, 27 Mar 2024 15:21:37 -0400 Subject: [PATCH 10/17] unit test & coverage --- .github/workflows/blui-ci.yml | 57 ++++++++++++++++++----------------- 1 file changed, 29 insertions(+), 28 deletions(-) diff --git a/.github/workflows/blui-ci.yml b/.github/workflows/blui-ci.yml index 6707248f..f073bc33 100644 --- a/.github/workflows/blui-ci.yml +++ b/.github/workflows/blui-ci.yml @@ -34,37 +34,38 @@ jobs: cache-dependency-path: login-workflow - run: yarn install:dependencies working-directory: login-workflow - # - run: yarn prettier - # working-directory: login-workflow - # - run: yarn lint - # working-directory: login-workflow + - run: yarn prettier + working-directory: login-workflow + - run: yarn lint + working-directory: login-workflow - # unit_test: - # runs-on: ubuntu-latest + unit_test: + runs-on: ubuntu-latest - # strategy: - # matrix: - # node-version: [18.x] + strategy: + matrix: + node-version: [18.x] - # steps: - # - uses: actions/checkout@v4 - # - name: Use Node.js ${{ matrix.node-version }} - # uses: actions/setup-node@v4 - # with: - # node-version: ${{ matrix.node-version }} - # cache: 'yarn' - # - run: yarn --frozen-lockfile - # working-directory: login-workflow - # - run: yarn test:ci --coverage --watchAll=false - # working-directory: login-workflow - # - name: Upload to Codecov - # uses: codecov/codecov-action@v3 - # with: - # directory: ./coverage/ - # files: clover.xml - # flags: unittests - # name: codecov-report - # verbose: true + steps: + - uses: actions/checkout@v4 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node-version }} + cache: 'yarn' + cache-dependency-path: login-workflow + - run: yarn --frozen-lockfile + working-directory: login-workflow + - run: yarn test:ci --coverage --watchAll=false + working-directory: login-workflow + - name: Upload to Codecov + uses: codecov/codecov-action@v3 + with: + directory: ./coverage/ + files: clover.xml + flags: unittests + name: codecov-report + verbose: true # build: # runs-on: ubuntu-latest From b71dd5f034b6c486d714020db1439f2d34429459 Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Wed, 27 Mar 2024 15:28:00 -0400 Subject: [PATCH 11/17] coverage path --- .github/workflows/blui-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/blui-ci.yml b/.github/workflows/blui-ci.yml index f073bc33..8a174743 100644 --- a/.github/workflows/blui-ci.yml +++ b/.github/workflows/blui-ci.yml @@ -61,7 +61,7 @@ jobs: - name: Upload to Codecov uses: codecov/codecov-action@v3 with: - directory: ./coverage/ + directory: ./login-workflow/coverage/ files: clover.xml flags: unittests name: codecov-report From f7a8f0d3e0c694bbeb30ab4d74dd3de5a8d8c04c Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Wed, 27 Mar 2024 15:39:59 -0400 Subject: [PATCH 12/17] build step --- .github/workflows/blui-ci.yml | 45 ++++++++++++++++++----------------- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/.github/workflows/blui-ci.yml b/.github/workflows/blui-ci.yml index 8a174743..5b552946 100644 --- a/.github/workflows/blui-ci.yml +++ b/.github/workflows/blui-ci.yml @@ -67,27 +67,28 @@ jobs: name: codecov-report verbose: true - # build: - # runs-on: ubuntu-latest + build: + runs-on: ubuntu-latest - # strategy: - # matrix: - # node-version: [18.x] + strategy: + matrix: + node-version: [18.x] - # steps: - # - uses: actions/checkout@v4 - # - name: Use Node.js ${{ matrix.node-version }} - # uses: actions/setup-node@v4 - # with: - # node-version: ${{ matrix.node-version }} - # cache: 'yarn' - # - run: yarn --frozen-lockfile - # working-directory: login-workflow - # - run: yarn build - # working-directory: login-workflow - # - name: Save build - # uses: actions/upload-artifact@v3 - # with: - # name: dist - # if-no-files-found: error - # path: dist \ No newline at end of file + steps: + - uses: actions/checkout@v4 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node-version }} + cache: 'yarn' + cache-dependency-path: login-workflow + - run: yarn --frozen-lockfile + working-directory: login-workflow + - run: yarn build + working-directory: login-workflow + - name: Save build + uses: actions/upload-artifact@v3 + with: + name: dist + if-no-files-found: error + path: dist \ No newline at end of file From 7d1a11e75301c1a105c85d9030402d0763cb559a Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Wed, 27 Mar 2024 16:04:37 -0400 Subject: [PATCH 13/17] save path --- .github/workflows/blui-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/blui-ci.yml b/.github/workflows/blui-ci.yml index 5b552946..267bd4be 100644 --- a/.github/workflows/blui-ci.yml +++ b/.github/workflows/blui-ci.yml @@ -91,4 +91,4 @@ jobs: with: name: dist if-no-files-found: error - path: dist \ No newline at end of file + path: login-workflow/dist \ No newline at end of file From 47089f5dedd24a883fa8c4b1ccfa761425097f60 Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Thu, 28 Mar 2024 10:10:38 -0400 Subject: [PATCH 14/17] add publish job --- .github/workflows/blui-ci.yml | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/.github/workflows/blui-ci.yml b/.github/workflows/blui-ci.yml index 267bd4be..ab9e216d 100644 --- a/.github/workflows/blui-ci.yml +++ b/.github/workflows/blui-ci.yml @@ -67,7 +67,7 @@ jobs: name: codecov-report verbose: true - build: + build_login_workflow: runs-on: ubuntu-latest strategy: @@ -91,4 +91,28 @@ jobs: with: name: dist if-no-files-found: error - path: login-workflow/dist \ No newline at end of file + path: login-workflow/dist + + publish_login_workflow: + runs-on: ubuntu-latest + if: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/master' || github.ref == 'refs/heads/dev') }} + needs: build_login_workflow + strategy: + matrix: + node-version: [18.x] + env: + NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} + BRANCH: ${{ github.ref == 'refs/heads/master' && 'master' || 'dev' }} + steps: + - uses: actions/checkout@v4 + - name: Download dist + uses: actions/download-artifact@v3 + with: + name: dist + path: login-workflow/dist + - uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node-version }} + registry-url: 'https://registry.npmjs.org' + - run: yarn --frozen-lockfile + - run: yarn publish:package -b ${{env.BRANCH}} \ No newline at end of file From 721528fc5f7b60eb892fd71d76ff4fee1ac82b59 Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Thu, 28 Mar 2024 10:28:22 -0400 Subject: [PATCH 15/17] add job dependency --- .github/workflows/blui-ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/blui-ci.yml b/.github/workflows/blui-ci.yml index ab9e216d..6bf6b297 100644 --- a/.github/workflows/blui-ci.yml +++ b/.github/workflows/blui-ci.yml @@ -41,6 +41,7 @@ jobs: unit_test: runs-on: ubuntu-latest + needs: prettier_lint strategy: matrix: @@ -69,6 +70,7 @@ jobs: build_login_workflow: runs-on: ubuntu-latest + needs: unit_test strategy: matrix: @@ -114,5 +116,6 @@ jobs: with: node-version: ${{ matrix.node-version }} registry-url: 'https://registry.npmjs.org' + cache-dependency-path: login-workflow - run: yarn --frozen-lockfile - run: yarn publish:package -b ${{env.BRANCH}} \ No newline at end of file From 63b75ecfb93664c2c992ff3752ff1bd074d2fbcf Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Thu, 28 Mar 2024 10:58:47 -0400 Subject: [PATCH 16/17] publish job waits for all jobs to complete --- .github/workflows/blui-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/blui-ci.yml b/.github/workflows/blui-ci.yml index 6bf6b297..fb7e3f68 100644 --- a/.github/workflows/blui-ci.yml +++ b/.github/workflows/blui-ci.yml @@ -98,7 +98,7 @@ jobs: publish_login_workflow: runs-on: ubuntu-latest if: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/master' || github.ref == 'refs/heads/dev') }} - needs: build_login_workflow + needs: [prettier_lint, unit_test, build_login_workflow] strategy: matrix: node-version: [18.x] From a5f3a5193062e16403554a54354f9d0d50001edf Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Thu, 28 Mar 2024 10:59:59 -0400 Subject: [PATCH 17/17] remove indivdual job deps --- .github/workflows/blui-ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/blui-ci.yml b/.github/workflows/blui-ci.yml index fb7e3f68..e42936f3 100644 --- a/.github/workflows/blui-ci.yml +++ b/.github/workflows/blui-ci.yml @@ -41,7 +41,6 @@ jobs: unit_test: runs-on: ubuntu-latest - needs: prettier_lint strategy: matrix: @@ -70,7 +69,6 @@ jobs: build_login_workflow: runs-on: ubuntu-latest - needs: unit_test strategy: matrix: