From edf661acb906d672e48a67a96cf0836ec42de40c Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Wed, 24 Jan 2024 15:23:28 -0500 Subject: [PATCH 1/4] Fix persist coverage & require test result --- .circleci/config.yml | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 3f522d3c..5e4485dc 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -91,6 +91,10 @@ jobs: command: | cd login-workflow yarn test:ci --maxWorkers=2 --coverage --watchAll=false + - persist_to_workspace: + root: . + paths: + - login-workflow/coverage build_login_workflow: docker: @@ -168,9 +172,9 @@ workflows: - dev - coverage_report: requires: - - build_login_workflow - filters: - branches: - only: - - master - - dev + - store_test_results + # filters: + # branches: + # only: + # - master + # - dev From 86a9b8d78d59b14316e26e93e0400588ccae1385 Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Wed, 24 Jan 2024 15:26:22 -0500 Subject: [PATCH 2/4] remove dup key --- .circleci/config.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 5e4485dc..43a063fd 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -122,7 +122,6 @@ jobs: root: . paths: - login-workflow/dist - - login-workflow/coverage coverage_report: working_directory: ~/login-workflow From c0f3f84b1bf7e007cc8e1157669ff5dc7ba8a339 Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Wed, 24 Jan 2024 15:27:41 -0500 Subject: [PATCH 3/4] format step --- .circleci/config.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 43a063fd..24a418a1 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -92,9 +92,9 @@ jobs: cd login-workflow yarn test:ci --maxWorkers=2 --coverage --watchAll=false - persist_to_workspace: - root: . - paths: - - login-workflow/coverage + root: . + paths: + - login-workflow/coverage build_login_workflow: docker: From 7c1b5bae805fa1723ed590e90d448942e3182012 Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Wed, 24 Jan 2024 15:39:56 -0500 Subject: [PATCH 4/4] turn filters on --- .circleci/config.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 24a418a1..504185fb 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -172,8 +172,8 @@ workflows: - coverage_report: requires: - store_test_results - # filters: - # branches: - # only: - # - master - # - dev + filters: + branches: + only: + - master + - dev