From 3dd0112fd0495c4a6da96c286fa39f260cf3fb71 Mon Sep 17 00:00:00 2001 From: jeffgreiner-eaton Date: Tue, 10 Dec 2024 13:58:59 -0500 Subject: [PATCH] update on PR --- .../firebase-hosting-pull-request.yml | 11 ++------- login-workflow/firebase.json | 24 +++++++++++-------- 2 files changed, 16 insertions(+), 19 deletions(-) diff --git a/.github/workflows/firebase-hosting-pull-request.yml b/.github/workflows/firebase-hosting-pull-request.yml index a5f04933..0faecdf2 100644 --- a/.github/workflows/firebase-hosting-pull-request.yml +++ b/.github/workflows/firebase-hosting-pull-request.yml @@ -6,19 +6,12 @@ name: Deploy to Firebase Hosting on PR -on: - pull_request: - branches: - - '*/*' - pull_request_target: - types: - - opened - branches: - - '*/*' +on: pull_request permissions: pull-requests: write contents: read + checks: write jobs: build_and_preview: diff --git a/login-workflow/firebase.json b/login-workflow/firebase.json index 4618be3b..78a26c73 100644 --- a/login-workflow/firebase.json +++ b/login-workflow/firebase.json @@ -1,12 +1,16 @@ { - "hosting": { - "public": "example/build", - "ignore": ["firebase.json", "**/.*", "**/node_modules/**"], - "rewrites": [ - { - "source": "**", - "destination": "/index.html" - } - ] - } + "hosting": { + "public": "example/build", + "ignore": [ + "firebase.json", + "**/.*", + "**/node_modules/**" + ], + "rewrites": [ + { + "source": "**", + "destination": "/index.html" + } + ] + } }