Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logic about heuristic sampling #416

Open
uestcyile opened this issue Nov 20, 2024 · 0 comments
Open

logic about heuristic sampling #416

uestcyile opened this issue Nov 20, 2024 · 0 comments

Comments

@uestcyile
Copy link

In source code heuristic-sampling.cc for map-sparsification, I see the code of get score and cost for each landmark.
But what confuse me is that you add score and cost, as the picture bellow shows:
image
To my understanding, landmark with higher socre means better quality, and lower cost also means better quality, so should we use "score minus cost" as the final quality metric instead of "score plus cost" ?
And the code should be "double score_and_cost = landmark_scores[landmark_id] - landmark_costs[landmark_id];" , right ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant