Make log send async #1174
Make log send async #1174
Conversation
|
@eastandwestwind I got all the tests passing now. |
There was a problem hiding this comment.
Great work on this @sanders41! Kinda glad we tackled this groundwork first, since now we'll only have to replace our _AnalyticsClient__send with using send again, once fideslog is released.
Just one question and 1 blocker to address.
|
|
||
|
|
||
| @pytest.fixture(scope="session", autouse=True) | ||
| def event_loop(): |
There was a problem hiding this comment.
could you explain why this is needed specifically for tests?
There was a problem hiding this comment.
It happens to be the same issue we are solving with the async log. When running the async tests it will sometimes start up multiple event loops and cause errors. I have found that using this fixture in my other async code bases has prevent the error.
| from typing import Any, Callable | ||
|
|
||
|
|
||
| def sync(func: Callable) -> Any: |
There was a problem hiding this comment.
oh nice workaround!
fidesops.toml
Outdated
| @@ -41,6 +41,7 @@ worker_enabled = false | |||
|
|
|||
| [root_user] | |||
| analytics_opt_out = false | |||
| analytics_id = "bc03820cc476fd0bb87322950f07b295" | |||
There was a problem hiding this comment.
We'll need to remove this.
@sanders41 — which containers are you running? I wonder if the cause is the same this time.
There was a problem hiding this comment.
I ran lots of the nox commands on this one. Unfortunately I was watching for this and still somehow missed it so I'm not sure which one triggered it.
* Make log send async * Update CHANGELOG * Add async to additional fideslog calls * WIP * Fix issue with async function is celery * Make __send work with name mangling * Remove extra await * Await coroutines in tests * Remove analytics id Co-authored-by: Paul Sanders <[email protected]>
Purpose
Resolve the issue listed in ethyca/fideslog#71
Changes
Checklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #