Expose async send #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests fail because the api is never installed and there is not information for how to install it in |
eastandwestwind
approved these changes
Aug 29, 2022
|
@sanders41 Should this be merged still or has the PR gone stale? |
|
It would be good, but we put in a work around to still use the function without this PR on the fidesops side so we got the same functionality without it. |
|
I see. Does it make sense to merge it in because the work is already done or would it just add dead code that won't be used? |
|
What we have now is working so I think it is fine to just close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71
This is to exposes the async send to external callers. By allowing this, when async programs are running they use their own even loop rather than having 2 loops start. In my testing this solved the issue in #71.
I left the
sendoption also so non-async programs (ie fidesctl with Click) can still call it as they have been.