Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fides.gtm() should happen as part of the base fides.js script #4169

Open
eastandwestwind opened this issue Sep 27, 2023 · 0 comments
Open

Fides.gtm() should happen as part of the base fides.js script #4169

eastandwestwind opened this issue Sep 27, 2023 · 0 comments

Comments

@eastandwestwind
Copy link
Contributor

Is your feature request related to a specific problem?

The problem is that Fides.gtm() is an additional call that is required as part of the onboarding process and can lead to both additional setup time and confusion for customers as they are setting up GTM itself.

Describe the solution you'd like

  • Maintain backwards compatibility. We have current customers calling the Fides.gtm() method. We can replace it with a method that does nothing, with a warning that it's deprecated, but it still needs to exist and not error.
  • Add a new config env var (default is true) enableGTM, and if it's true, we 1) add pushFidesVariableToGTM to our "FidesInitialized" and "FidesUpdated" event listeners and 2) ensure we're calling pushFidesVariableToGTM on Fides initialization (likely not needed if we just add to our event listeners).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants