Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change things to internal instead of public #22

Open
ethorad opened this issue May 21, 2023 · 2 comments
Open

change things to internal instead of public #22

ethorad opened this issue May 21, 2023 · 2 comments
Labels
general General changes

Comments

@ethorad
Copy link
Owner

ethorad commented May 21, 2023

Have been using public as the way to expose things between classes. Change it all to protected instead, as that seems to expose within the program but not outside the program
@ethorad ethorad added the general General changes label May 21, 2023
@ethorad
Copy link
Owner Author

ethorad commented May 23, 2023

seems that viewmodel stuff needs to be public for the window class to be able to see them

@ethorad
Copy link
Owner Author

ethorad commented Jun 23, 2023

Instead of protected, I think I meant internal

@ethorad ethorad changed the title change things to protected instead of public change things to internal instead of public Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
general General changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ethorad