Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documenting optional method parameters? #7

Open
SjonHortensius opened this issue Jul 31, 2017 · 1 comment
Open

Documenting optional method parameters? #7

SjonHortensius opened this issue Jul 31, 2017 · 1 comment

Comments

@SjonHortensius
Copy link
Contributor

There are a few optional method parameters which are not included in the schema. Would you be interested in a PR to fix that?

It's a very small list (most parameters are required):

  • eth_call/1
  • eth_estimateGas/1
  • eth_getBalance/1
  • eth_getStorageAt/2
  • eth_getTransactionCount/1

I propose to include {"methods":{"__optional":{"eth_call":[1],"eth_estimateGas":[1]}} to document this
SjonHortensius added a commit to SjonHortensius/ethjs-schema that referenced this issue Jul 31, 2017
@SjonHortensius
Add schema.__optional which lists optional method parameters ethjs#7
32e932c 
instead of listing required, as 99% of all parameters are required
SjonHortensius added a commit to SjonHortensius/ethjs-schema that referenced this issue Jul 31, 2017
@SjonHortensius
Add schema.__optional which lists optional method parameters ethjs#7
402205e 
instead of listing required, as 99% of all parameters are required
SjonHortensius added a commit to SjonHortensius/ethjs-schema that referenced this issue Jul 31, 2017
@SjonHortensius
Add schema.__optional which lists optional method parameters ethjs#7
df84dd6 
instead of listing required, as 99% of all parameters are required
SjonHortensius added a commit to SjonHortensius/ethjs-schema that referenced this issue Jul 31, 2017
@SjonHortensius
Add schema.__optional which lists optional method parameters ethjs#7
8558bd2 
instead of listing required, as 99% of all parameters are required
@SilentCicero
Copy link
Member

I'll need to think about this, this has been brought up before. And would be some bigger changes in ethjs-query. Will consider.

SjonHortensius added a commit to SjonHortensius/ethjs-schema that referenced this issue Aug 16, 2019
@SjonHortensius
Add schema.__optional which lists optional method parameters ethjs#7
6d13db9 
instead of listing required, as 99% of all parameters are required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SjonHortensius @SilentCicero