In light-client, use ethereum_ssz instead of ssz-rs

[carver]

ethereum_ssz is used for SSZ handling in most places, but light-client uses ssz-rs. Investigate replacing ssz-rs, so we can remove a dependency.

[virajbhartiya]

Can I work on this?

[KolbyML]

@virajbhartiya yes you can work on it 🚀

[virajbhartiya]

@KolbyML @carver While looking at the implementation of ethereum_ssz, I couldn't find Vector, Node, etc in it. I also went through its usage in trin-beacon and trin-history. If I am missing something can you please help me out with this?

[KolbyML]

@KolbyML @carver While looking at the implementation of ethereum_ssz, I couldn't find Vector, Node, etc in it. I also went through its usage in trin-beacon and trin-history. If I am missing something can you please help me out with this?

Could you give me an example of code you are trying to update but having problems with? Or link to the lines of code which use Vector`, `Node you are referring to?

[virajbhartiya]

Eg:

trin/light-client/src/consensus/consensus_client.rs

Lines 571 to 574 in 3c33623

	) -> Result<Node> {
	let genesis_root = genesis_root.to_vec().try_into()?;
	let domain_type = &hex::decode("07000000")?[..];
	let fork_version = Vector::from_iter(fork_version.to_vec());

also

trin/light-client/src/types.rs

Lines 1 to 3 in 3c33623

	use ssz_rs::Vector;
	pub type Bytes32 = Vector<u8, 32>;

If I try removing ssz-rs, I was unable to find a replacement for these in ethereum_ssz, if it is okay to replace it with [u8] I can try to update the usages

[KolbyML]

Eg:

trin/light-client/src/consensus/consensus_client.rs

Lines 571 to 574 in 3c33623

	) -> Result<Node> {
	let genesis_root = genesis_root.to_vec().try_into()?;
	let domain_type = &hex::decode("07000000")?[..];
	let fork_version = Vector::from_iter(fork_version.to_vec());

also

trin/light-client/src/types.rs

Lines 1 to 3 in 3c33623

	use ssz_rs::Vector;
	pub type Bytes32 = Vector<u8, 32>;

If I try removing ssz-rs, I was unable to find a replacement for these in ethereum_ssz, if it is okay to replace it with [u8] I can try to update the usages

So for vector you should be able to use FixedVector from this library https://docs.rs/ssz_types/latest/ssz_types/ to read more on SSZ types you can find info here https://github.com/ethereum/consensus-specs/blob/dev/ssz/simple-serialize.md

Example usage can be found in our ethportal-api crate which uses ethereum_ssz and ssz_types

You didn't give an example for Node, but the process should be fairly similar feel free to ask more questions if you are still confused.

[virajbhartiya]

Thanks for helping out with Vector, I'll make the change,

Example for the usage of Node

trin/light-client/src/consensus/utils.rs

Line 55 in 3c33623

pub fn compute_signing_root(object_root: Bytes32, domain: Bytes32) -> Result<Node> {

trin/light-client/src/consensus/consensus_client.rs

Line 571 in 3c33623

) -> Result<Node> {

[virajbhartiya]

Another issue is with

trin/light-client/src/consensus/utils.rs

Line 36 in 3c33623

let is_valid = is_valid_merkle_branch(&leaf_hash, branch.iter(), depth, index, &state_root);

[KolbyML]

Thanks for helping out with Vector, I'll make the change,

Example for the usage of Node

trin/light-client/src/consensus/utils.rs

Line 55 in 3c33623

pub fn compute_signing_root(object_root: Bytes32, domain: Bytes32) -> Result<Node> {

trin/light-client/src/consensus/consensus_client.rs

Line 571 in 3c33623

) -> Result<Node> {

In ethereum_ssz the type Node would be B256

[virajbhartiya]

@KolbyML I have raised a PR for this, I was unable to find a fix for is_valid_merkle_branch and hash_tree_root. If you could help me out with that it'll be great, thanks!

[KolbyML]

@KolbyML I have raised a PR for this, I was unable to find a fix for is_valid_merkle_branch and hash_tree_root. If you could help me out with that it'll be great, thanks!

You should be able to use this crate as a replacement https://docs.rs/tree_hash/latest/tree_hash/ we use it in ethportal-api so you can probably find an example. The rust derive's name is Hash I believe, it is used for the consensus types