Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust RecursiveFindContent | Continue the search if data transfer fails #1383

Closed
KolbyML opened this issue Aug 15, 2024 · 2 comments · Fixed by #1467
Closed

Robust RecursiveFindContent | Continue the search if data transfer fails #1383

KolbyML opened this issue Aug 15, 2024 · 2 comments · Fixed by #1467
Assignees
Labels
enhancement New feature or request shelf-stable Will not be closed by stale-bot

Comments

@KolbyML
Copy link
Member

KolbyML commented Aug 15, 2024

image

Clients can have bugs, trin has had bugs, shisui has, ultralight etc. A bug in a client shouldn't stop the whole show. A bug we were seeing was trin found the content from a shisui or trin node, then the uTP transfer would fail for some unknown reason, then we would just return an error.

Instead of this we could continue the search until we find a working peer, we already did a big search to find the contents neighbourhood so it isn't out of question if the first node we try to get the data from fails, we just try another and continue the search to some failure level till we either fail X times and give up or successfully fetch the data.

@KolbyML KolbyML added enhancement New feature or request shelf-stable Will not be closed by stale-bot labels Aug 15, 2024
@KolbyML KolbyML changed the title Robust RecursiveFindContent Robust RecursiveFindContent | Continue the search if data transfer fails Aug 15, 2024
@morph-dev
Copy link
Collaborator

@carver if I understood correctly, you said you are looking into this or something similar, right? Maybe you can add your progress or assign it to yourself if that's the case

@carver
Copy link
Collaborator

carver commented Sep 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request shelf-stable Will not be closed by stale-bot
Projects
None yet
3 participants