Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccurate info in README #3

Open
dev-dan opened this issue Apr 29, 2016 · 2 comments
Open

Inaccurate info in README #3

dev-dan opened this issue Apr 29, 2016 · 2 comments

Comments

@dev-dan
Copy link
Contributor

dev-dan commented Apr 29, 2016 •
edited
Loading

Krakken API no longer used but still referenced in README.
Doc's detail usage of unit references that are not utilized in the code. Am not clear if these were deprecated or are net yet implemented.
@frozeman
Copy link
Contributor

Yes we now use crypto compares API, can you change the text to them?

@dev-dan
Copy link
Contributor Author

dev-dan commented Apr 29, 2016

Sure! I will update the API Info now.

Want about the units in the README.md?

It states - btc, usd, eur, cad, gbp, jpy are possible for some methods, but as far as I can see only usd, eur, and btc are enabled through supportedCurrencies, and only usd/btc is supported through the current cryptocompare api call.

Should the text of support for those units be removed until the code is extended to support the additional units or is there something I missed that facilitates these units?

@hackmod hackmod mentioned this issue Apr 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frozeman @dev-dan