Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

Multisig support for subtokens #193

Closed
taoteh1221 opened this issue May 18, 2016 · 14 comments
Closed

Multisig support for subtokens #193

taoteh1221 opened this issue May 18, 2016 · 14 comments

Comments

@taoteh1221
Copy link

Moved this from the Mist repo at the request of @luclu : ethereum/mist#660

It would be really great if there was a multisig security option to protect subtokens (TheDAO, Unicorns, etc)? I believe right now there is not an available security option yet for subtokens in multisig wallets?

@olivierstern
Copy link
Contributor

That's a good point. Daily minimum withdraw applies to ether, not tokens. Maybe add a setting that requires or doesn't require confirmations regardless of the amount ?

@taoteh1221
Copy link
Author

@olivierstern I think they'd model it after their current ETH multisig, so no extra sigs àre required below a certain amount for subtokens as well.

@olivierstern
Copy link
Contributor

You would need then to add a setting per token which is not doable with a standard wallet contract, because otherwise with a single minimum setting for all tokens it is irrelevant, because the intrinsic value of the tokens can vary a lot from one another, or I miss something ? Then to me the best solution to keep it simple is to allow or ban token transfer without confirmation.

@taoteh1221
Copy link
Author

@olivierstern No clue myself, hopefully they come up with something good. 😄

@luclu
Copy link
Contributor

luclu commented Jul 5, 2016

This designated new wallet contract will require any non-Ether-token to be confirmed regardless of the amount:
ethereum/dapp-bin#62
ethereum/mist#783

@taoteh1221
Copy link
Author

@luclu Great news. Has this been included in Mist v0.7.6 wallet contract deployment, or do I have to wait for a future Mist release?

@luclu
Copy link
Contributor

luclu commented Jul 5, 2016

The ETA is currently 1.0 - but this is more a symbolic milestone. Expect this to be be introduced earlier.

@olivierstern
Copy link
Contributor

Very good news !! Nice job

@taoteh1221
Copy link
Author

Awesome, thanks for all your hard work. 👍

@luclu
Copy link
Contributor

luclu commented Nov 29, 2016

We are looking forward to switch to this wallet, which will have token support.

@taoteh1221
Copy link
Author

@luclu Awesome. Looking forward to securing ERC20 crowdsale tokens. Any specifics yet on what version of Mist will have this?

@luclu
Copy link
Contributor

luclu commented Dec 1, 2016

As it is still work in progress and didn't undertake any serious audit yet I don't expect it to be included in the next 1-2 months. Though I would love to see it sooner than later.

@taoteh1221
Copy link
Author

Thanks very much for your responses. :)

@taoteh1221
Copy link
Author

Has the default Mist multisig been upgraded to secured ERC20 token support yet, regarding X of X sigs required for ERC20 token withdrawals?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants