-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(indexer) API Observability for Bridge Supplies #7680
Merged
hamdiallam
merged 5 commits into
ethereum-optimism:develop
from
epociask:indexer.api.supply_view
Nov 8, 2023
Merged
feat(indexer) API Observability for Bridge Supplies #7680
hamdiallam
merged 5 commits into
ethereum-optimism:develop
from
epociask:indexer.api.supply_view
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
hamdiallam
reviewed
Nov 2, 2023
Codecov Report
@@ Coverage Diff @@
## develop #7680 +/- ##
===========================================
- Coverage 46.08% 45.76% -0.33%
===========================================
Files 170 170
Lines 7121 7121
Branches 1138 1138
===========================================
- Hits 3282 3259 -23
- Misses 3712 3734 +22
- Partials 127 128 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
hamdiallam
approved these changes
Nov 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 8, 2023
Merged
via the queue into
ethereum-optimism:develop
with commit Nov 8, 2023
30cacfa
62 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests
Updated E2E test to generate supply amounts locally and cross validate with amounts returned by API client.
Additional context
base-org/pessimism#148
Metadata