Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(indexer) API Observability for Bridge Supplies #7680

Merged
merged 5 commits into from
Nov 8, 2023
Merged

feat(indexer) API Observability for Bridge Supplies #7680

merged 5 commits into from
Nov 8, 2023

Conversation

epociask
Copy link
Contributor

Description

  • Added new endpoint

Tests
Updated E2E test to generate supply amounts locally and cross validate with amounts returned by API client.

Additional context

base-org/pessimism#148

Metadata

  • Fixes #[Link to Issue]

@github-actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Oct 29, 2023
@epociask epociask marked this pull request as ready for review November 6, 2023 23:49
@epociask epociask requested a review from a team as a code owner November 6, 2023 23:49
@epociask epociask requested a review from hamdiallam November 6, 2023 23:49
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #7680 (fd47aec) into develop (88eee4f) will decrease coverage by 0.33%.
Report is 77 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #7680      +/-   ##
===========================================
- Coverage    46.08%   45.76%   -0.33%     
===========================================
  Files          170      170              
  Lines         7121     7121              
  Branches      1138     1138              
===========================================
- Hits          3282     3259      -23     
- Misses        3712     3734      +22     
- Partials       127      128       +1     
Flag Coverage Δ
cannon-go-tests 63.47% <ø> (ø)
chain-mon-tests 26.95% <ø> (ø)
common-ts-tests 26.74% <ø> (ø)
contracts-bedrock-tests 39.54% <ø> (-0.79%) ⬇️
contracts-ts-tests 100.00% <ø> (ø)
core-utils-tests 44.03% <ø> (ø)
sdk-next-tests 41.92% <ø> (ø)
sdk-tests 41.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@hamdiallam hamdiallam added this pull request to the merge queue Nov 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2023
@hamdiallam hamdiallam added this pull request to the merge queue Nov 8, 2023
Merged via the queue into ethereum-optimism:develop with commit 30cacfa Nov 8, 2023
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants