Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOP/PLAY button. #28

Open
fernando-inf opened this issue Oct 16, 2021 · 10 comments
Open

STOP/PLAY button. #28

fernando-inf opened this issue Oct 16, 2021 · 10 comments

Comments

@fernando-inf
Copy link

Hi, why is there no STOP button? There is only one from PAUSE. I think a STOP is necessary to be able to assign a MIDI CC to it. Thanks.

@essej
Copy link
Owner

essej commented Oct 16, 2021

Originally there was only Mute (time keeps going so that things are still in sync)… people eventually talked me into adding Pause which is effecfively stop. You have the choice on how to resume it, either unpause (to start from where it was) or retrigger (to start from loop begin).

If you want to stop all loops you bind a midi control to pause for All loops.

@fernando-inf
Copy link
Author

fernando-inf commented Oct 16, 2021

Thanks for answering, so far I programmed my MIDI PEDALBOARD, to only have 2 pedals in LOOP MODE: RECORD and STOP/PLAY (although I had to assign it to PAUSE in sooperlooper). Using "TRIG" would imply adding another pedal, but if there is no other option I will have to do it. Thanks for answering.

@fernando-inf fernando-inf changed the title STOP button. STOP/PLAY button. Oct 16, 2021
@essej
Copy link
Owner

essej commented Oct 16, 2021

I think what SL needs is a pause_or_trigger command, where it will pause if it's playing, and trigger if it's not.

@fernando-inf
Copy link
Author

I think what SL needs is a pause_or_trigger command, where it will pause if it's playing, and trigger if it's not.

Yes, it would be a good advance to minimize the number of pedals.
Now that I think about it, what you suggest would be the same as a STOP / PLAY button, good idea.

@fernando-inf
Copy link
Author

This would be useful for cases in which, due to human error, the PAUSE button is pressed late, then restarting the loop from 0 the next time it is pressed is the solution, that is why a single STOP / PLAY or PAUSE / TRIG button it would be good.

@essej
Copy link
Owner

essej commented Oct 16, 2021

I think what SL needs is a pause_or_trigger command, where it will pause if it's playing, and trigger if it's not.

Yes, it would be a good advance to minimize the number of pedals. Now that I think about it, what you suggest would be the same as a STOP / PLAY button, good idea.

Yes, it's the same thing since the restarting would happen with trigger from start.

@essej
Copy link
Owner

essej commented Oct 16, 2021

Oh, I forgot about the existing solution! The command called mute_trigger... which mutes if playing, triggers from start if muted. There you go!

@fernando-inf
Copy link
Author

The command called mute_trigger... which mutes if playing, triggers from start if muted. There you go!

I will try.

But doing just one MUTE keep the risk of getting XRUN any longer. The continuous playback even when is in MUTE puts unnecessary strain on the processor.

@essej
Copy link
Owner

essej commented Oct 16, 2021

The command called mute_trigger... which mutes if playing, triggers from start if muted. There you go!

I will try.

But doing just one MUTE keep the risk of getting XRUN any longer. The continuous playback even when is in MUTE puts unnecessary strain on the processor.

I really don't think that is concern at all, what actually happens in the code in the different states does not really affect CPU load at all. I wrote SL back in the early 2000s and it wasn't an issue with the hardware then (it was pretty low CPU usage even then). I don't know what hardware you are using now, but I'm 90% confident your concerns are unfounded.

@fernando-inf
Copy link
Author

fernando-inf commented Oct 16, 2021

Okay, I'll try mute_trigger.

My project uses Guitarix + Hydrogen + Sooperlooper. Sometimes when the 3 programs are active I have XRUN that feel strong, I suppose then that Hydrogen is the culprit. I use a board with an Intel 1037u (2013), but the idea in the future is to bring the headless project to Raspberry Pi:

https://github.com/fernando-inf/ARDUINO-GUITARIX-MIDI_PEDALBOARD

Greetings, thanks for responding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants