Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): removed Wno-format flag and fixed formatting warnings (IDFGH-7768) #326

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

gabsuren
Copy link
Contributor

@gabsuren gabsuren commented Jul 20, 2023

In this PR included

  • Fix of CI failure for esp modem host tests
  • Fix of esp_mqtt_cxx target tests

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2023

CLA assistant check
All committers have signed the CLA.

@gabsuren gabsuren changed the title fix(common): removed Wno-format flag and fixed formatting warnings fix(common): removed Wno-format flag and fixed formatting warnings (IDFGH-7768) Jul 20, 2023
@gabsuren gabsuren force-pushed the fix/fix_format_warnings branch from 6943133 to 051fdc8 Compare July 21, 2023 10:53
@gabsuren gabsuren force-pushed the fix/fix_format_warnings branch 4 times, most recently from 0938980 to d173d72 Compare July 26, 2023 07:21
@gabsuren gabsuren requested a review from david-cermak July 26, 2023 08:08
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@gabsuren gabsuren force-pushed the fix/fix_format_warnings branch 2 times, most recently from 411c7af to e8177b0 Compare August 17, 2023 17:49
@gabsuren gabsuren requested a review from david-cermak August 17, 2023 17:59
@gabsuren gabsuren force-pushed the fix/fix_format_warnings branch from e8177b0 to ebe0c47 Compare August 18, 2023 12:44
@gabsuren gabsuren self-assigned this Aug 22, 2023
@gabsuren gabsuren force-pushed the fix/fix_format_warnings branch 3 times, most recently from aeec2f4 to 91a8e6d Compare September 8, 2023 10:13
@gabsuren gabsuren force-pushed the fix/fix_format_warnings branch from 5a70243 to c48e442 Compare September 25, 2023 16:01
@gabsuren gabsuren merged commit 223647e into espressif:master Sep 25, 2023
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants