-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common): removed Wno-format flag and fixed formatting warnings (IDFGH-7768) #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabsuren
changed the title
fix(common): removed Wno-format flag and fixed formatting warnings
fix(common): removed Wno-format flag and fixed formatting warnings (IDFGH-7768)
Jul 20, 2023
gabsuren
force-pushed
the
fix/fix_format_warnings
branch
from
July 21, 2023 10:53
6943133
to
051fdc8
Compare
components/esp_modem/examples/modem_console/main/modem_console_main.cpp
Outdated
Show resolved
Hide resolved
gabsuren
force-pushed
the
fix/fix_format_warnings
branch
4 times, most recently
from
July 26, 2023 07:21
0938980
to
d173d72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
gabsuren
force-pushed
the
fix/fix_format_warnings
branch
2 times, most recently
from
August 17, 2023 17:49
411c7af
to
e8177b0
Compare
gabsuren
force-pushed
the
fix/fix_format_warnings
branch
from
August 18, 2023 12:44
e8177b0
to
ebe0c47
Compare
gabsuren
force-pushed
the
fix/fix_format_warnings
branch
3 times, most recently
from
September 8, 2023 10:13
aeec2f4
to
91a8e6d
Compare
david-cermak
approved these changes
Sep 25, 2023
gabsuren
force-pushed
the
fix/fix_format_warnings
branch
from
September 25, 2023 16:01
5a70243
to
c48e442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR included