Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to add component to project #22

Open
slompf18 opened this issue Jan 6, 2021 · 2 comments
Open

Make it easier to add component to project #22

slompf18 opened this issue Jan 6, 2021 · 2 comments

Comments

@slompf18
Copy link

slompf18 commented Jan 6, 2021

Adding the component as submodule in components directory of a project fails, until you add

set(EXTRA_COMPONENT_DIRS ${CMAKE_CURRENT_LIST_DIR}/components/esp-apple-homekit-adk)

to your CMakeLists.txt. I guess its because the CMakeLists.txt of the component is not in the root directory as stated here.

Is this an intended behavior? Otherwise I could fix it.

@shahpiyushv
Copy link
Collaborator

@slompf18 , there's no specific reason why CMakeLists.txt isn't in the root directory here. It's just that some of our other recent projects had multiple components in them and so we did not have the CMakeLists.txt for them in the root folder. The same logic got applied here, even though here it is a single component :)

@slompf18
Copy link
Author

slompf18 commented Jan 7, 2021

Should we correct it? It's a fast fix and would make life a little bit easier for others using the component. Actually I have fixed it on a branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants