-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIFI Example does not compile with the esp_idf_svc crate recommended in the esp-rs
book
#242
Comments
esp-rs
book
Yeah that is not ideal. The overall correct way would be to update the training to the latest esp-idf-svc release. Thanks for bringing up the issue. |
@Vollbrecht I wouldn't mind helping out. |
Feel free to create a PR, it probably would be enough to update every occurrence of esp-idf-svc in the Cargo.toml and test if all solution examples still work. Besides the mention wifi problem the esp-idf-svc API that is used in the training should not have changed much. |
On it. What's to determine is if using .try_into.unwrap() is sufficient. Alternatively, one would need to implement error handling in the style of anyhow for conversion errors. |
I think the training is using anyhow, so an context() with a panic massage would be ok here |
Done. Works on my machine. #243 |
When running a project templated by
esp-idf-template
and addingwifi.rs
fromcommon
, I can not successfully runcargo build
.I must admit, I'm a bit confused on the use of heapless in the esp_idf_svf::wifi Component. I thought the whole point of using the
std
feature flag was to enable the use of std::String.Note that I am aware of #233 and the usage of
heapless:v.08
, however, since theesp-rs
book links tostd-training
andstd-training
usesesp_idf_svc:v.0.47.3
and neither crate uses Semver past 1.0, users (like me) could be rightfully confused on compilation errors when using theesp-idf-template
instead of the providedworkshop
repository.I think we should consider moving from
.into
totry_from
, as the documentation ofheapless
suggests.Error:
The text was updated successfully, but these errors were encountered: