Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An instance of overzealous signature stripping #44

Open
domenic opened this issue Jun 24, 2013 · 4 comments
Open

An instance of overzealous signature stripping #44

domenic opened this issue Jun 24, 2013 · 4 comments

Comments

@domenic
Copy link

domenic commented Jun 24, 2013

Maybe it's triggered by "on my mobile"? http://esdiscuss.org/topic/shouldprotobeanaccessorpropertyofobjectprototype#content-2

@ForbesLindesay
Copy link
Member

It's caused by attempting to strip all instances of On Fri, Jun 21, 2013 at 11:34 PM, BelleveInvis <infinte.cdda at hotmail.com>wrote: like footers.

At the moment it strips any lines that contain on and at some later point contain 2 consecutive numbers. We will need to be a little more strict with that.

@domenic
Copy link
Author

domenic commented Jul 1, 2013

@domenic
Copy link
Author

domenic commented Jul 23, 2013

This is somewhat helped by the fact that signature stripping now happens pre-edits, i.e. you can edit to add the stripped stuff back in. I did that with the second example linked above.

@ForbesLindesay
Copy link
Member

Yes, that was a conscious decision, largely motivated by the case of a quote being the last part of a message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants