Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[epic] storybook #31

Open
43081j opened this issue Mar 1, 2024 · 3 comments
Open

[epic] storybook #31

43081j opened this issue Mar 1, 2024 · 3 comments
Labels
accepts prs The maintainer of the target repo was contacted and welcomes prs umbrella issue This issue contains a list of dependents of a package and tracks the progress in each

Comments

@43081j
Copy link
Collaborator

43081j commented Mar 1, 2024

storybook's dependency tree depends on the flavour of entrypoint you use.

so for this example, let's use the web-components package:
https://npmgraph.js.org/?q=@storybook/web-components-vite

there's quite a lot of deep subtrees we can probably trim out here.

good subtrees to remove are:

assert

Depended on by:

qs

Depended on by:

In most cases, we can likely either:

read-pkg-up

This has some use but the dependency tree is bloated for what it is, and there are more performant solutions.

If possible, we should use read-package-json-fast from npm themselves.

We could use fd-package-json:
https://github.com/es-tooling/fd-package-json

@43081j 43081j added the help wanted Extra attention is needed label Mar 1, 2024
@43081j
Copy link
Collaborator Author

43081j commented Mar 3, 2024

we can now replace read-pkg-up with fd-package-json:
https://github.com/es-tooling/fd-package-json

@benmccann
Copy link

express - not sure how likely PRs are to express

express itself is rather bulky and could be swapped out. I just did that in the Svelte repo, which luckily only took me a few lines there: sveltejs/svelte#12155

@43081j
Copy link
Collaborator Author

43081j commented Jun 23, 2024

you're right. i forgot to update this issue too!

i started the work in storybookjs/storybook#27045

although polka is tempting too. though i may do that in a later PR since it'll be an easier move than this one

@Fuzzyma Fuzzyma added accepts prs The maintainer of the target repo was contacted and welcomes prs umbrella issue This issue contains a list of dependents of a package and tracks the progress in each and removed help wanted Extra attention is needed labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepts prs The maintainer of the target repo was contacted and welcomes prs umbrella issue This issue contains a list of dependents of a package and tracks the progress in each
Projects
None yet
Development

No branches or pull requests

3 participants