Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google.Parens flags entire line if parenthesis contains a markdown link #30

Open
rainecheck opened this issue May 29, 2023 · 1 comment

Comments

@rainecheck
Copy link

Google.Parens triggers from the start of the line to the end of the line, if a link is included inside the parenthesis. Links outside of the parenthesis do not cause this. Triggers on both standard links, http://www.directlinks.example.com, and inline_links. Does not trigger for [text inside square brackets].

There is a prior line.
There is a prior sentence. Test sentence ([this](http://example.com)), please ignore. There is a following sentence.
There is a following line. When split across lines, it will only flag from the line itself.
It won't trigger for (text [inside square brackets] that aren't links)
An example of an ([inline_link][inline_links]).
An example of a (direct link: <http://www.example.com>)
@andrewvaughan
Copy link

I won't open another issue, but this also fails in Makefiles if you call any commands:

For example:

##
# Install dependencies for development
#
# Some of these changes may impact the Repository. Commit these changes if they occur.
#
dev-dependencies:
	$(call _title, Updating development dependencies)

	$(call _header, Updating prose style guide)
	echo
	rm -rf .config/linters/vale/styles/Google
	$(NPX) vale sync
	echo

Vale throws errors on all $( calls as well as calling the vale command calls; ideally it would only review comments (I'm having it ignore Makefiles altogether, for now):

 .config/make/50-build.mak
 27:3   suggestion  Use parentheses judiciously.   Google.Parens
 29:3   suggestion  Use parentheses judiciously.   Google.Parens
 31:25  error       Use 'Vale' instead of 'vale'.  Vale.Terms
 32:3   suggestion  Use parentheses judiciously.   Google.Parens
 32:9   error       Use 'Vale' instead of 'vale'.  Vale.Terms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants