Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioning #6

Open
davidfrantz opened this issue Jan 17, 2023 · 3 comments
Open

versioning #6

davidfrantz opened this issue Jan 17, 2023 · 3 comments

Comments

@davidfrantz
Copy link
Contributor

Hi Stefan,

I see quite some activity in the FORCE git with respect to patching landsatlinks. Thanks for being so rapid and active there.

I wonder whether it would help you to prevent people from running outdated versions, to implement some sort of versioning?

As of now, we seem to run v1.0.0, although there has been some bugfixes:

frantz@ahsoka:~$ dforce force-level1-landsat -v
landsatlinks version 1.0.0 https://github.com/ernstste/landsatlinks

I totally understand if tagging and creating releases is too much overhead, but wouldn't some sort of workflow to bump the version whenever you push to main be a sensible solution?

Cheers,
David

@ernstste
Copy link
Owner

Absolutely. This is why I started using a versioning system that allows for referencing small bugfixes like the last ones.
Problem is that there were too many things happening at the same time and i was just pushing out fixes quickly inbetween other task - "I'll do it now or it's not going to be taken care of anytime soon".
I'll try to tag commits more regularly, thanks for bringing this up 👍

@davidfrantz
Copy link
Contributor Author

I can totally relate, and this is in parts why I mostly put bugfixes in the dev branch ;)

Anyways, I have a version bump script in my repo, in case you want to steal and adapt it. It does not take care of tagging, but can swap versions in your code for stdout printing.

@ernstste
Copy link
Owner

Thanks I will take a look. I'll probably go with a gh workflow that triggers whenever there are new commits with certain keywords. That should be the easiest solution in the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants