Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting "3" for rebar version doesn't select the latest version compatible with selected OTP version #307

Open
pguyot opened this issue Oct 21, 2024 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@pguyot
Copy link
Contributor

pguyot commented Oct 21, 2024

The bug

When choosing "3" for rebar.version, the latest rebar 3 is selected while it was expected to have the latest rebar3 compatible with the selected OTP version (typically not 3.24.0 for OTP 21).

See: https://github.com/pguyot/AtomVM/actions/runs/11433923118/job/31806652030

How to replicate

https://github.com/pguyot/AtomVM/actions/runs/11433923118/workflow

    - uses: erlef/setup-beam@v1
      with:
        otp-version: ${{ matrix.otp }}
        elixir-version: ${{ matrix.elixir_version }}
        rebar3-version: "3"
        hexpm-mirrors: |
          https://builds.hex.pm
          https://repo.hex.pm
          https://cdn.jsdelivr.net/hex

Expected behaviour

Action should pick up a version of rebar3 that works with the selected OTP version.

@pguyot pguyot added the bug Something isn't working label Oct 21, 2024
@paulo-ferraz-oliveira paulo-ferraz-oliveira added help wanted Extra attention is needed and removed bug Something isn't working labels Oct 21, 2024
@paulo-ferraz-oliveira
Copy link
Collaborator

I don't think this is a bug (thus I removed the label) since there's no promise that the action should do what you're asking for. It might be a feature request for somebody to implement, though. 🤷

@paulo-ferraz-oliveira
Copy link
Collaborator

Also, fwiw, there's an ongoing attempt to identify the rebar3 vs Erlang/OTP version compatibility list: https://github.com/erlang/rebar3/pull/2918/files, in case somebody's interested. We'd discussed in the action, elsewhere, if any of such compatibility should be known/kept next to the action and we decided on "No", but as always stuff's revisitable.

@sebastiw
Copy link

this is one way to pin rebar3 versions with OTP-versions

#313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants