Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box2D not building on armeabi-v7a #813

Closed
bostick opened this issue Sep 30, 2024 · 1 comment
Closed

Box2D not building on armeabi-v7a #813

bostick opened this issue Sep 30, 2024 · 1 comment

Comments

@bostick
Copy link

bostick commented Sep 30, 2024

I am using Box2D for an Android project and with the latest commit on main branch (b864f53), I get an error when building on armeabi-v7a.

/Users/brenton/development/github/raylib-experiment/raymob/app/.cxx/Debug/q5f4v4e5/armeabi-v7a/_deps/box2d-src/src/contact_solver.c:670:9: error: call to undeclared function 'vzip1q_f32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        return vzip1q_f32( a, b );
               ^
/Users/brenton/development/github/raylib-experiment/raymob/app/.cxx/Debug/q5f4v4e5/armeabi-v7a/_deps/box2d-src/src/contact_solver.c:670:9: note: did you mean 'vzipq_f32'?
/Users/brenton/Library/Android/sdk/ndk/26.1.10909125/toolchains/llvm/prebuilt/darwin-x86_64/lib/clang/17/include/arm_neon.h:32079:20: note: 'vzipq_f32' declared here
__ai float32x4x2_t vzipq_f32(float32x4_t __p0, float32x4_t __p1) {
                   ^

vzip1q_f32 is A64 and not available on armeabi-v7a.

armeabi-v7a is a supported ABI:
https://developer.android.com/ndk/guides/abis

But this is not specific to Android, but this is the easiest way to demonstrate the problem.

bostick pushed a commit to bostick/box2d that referenced this issue Sep 30, 2024
Emulate vzip1q_f32 for 32-bit
erincatto added a commit that referenced this issue Oct 6, 2024
- optimized ray and shape cast : 2x faster
- update mass options instead of automatic mass
- fixes for 32-bit Windows build
- b2TreeStats for measuring query performance
- reduced tree node size from 48-bytes to 40-bytes
- fixes for 32-bit Neon
- MSVC warning level 4 and fixes
#814, #815, #813, #809
@erincatto
Copy link
Owner

I applied your Neon patches in #817. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants