Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace_transaction and trace_get not working #1833

Closed
tjayrush opened this issue Apr 28, 2021 · 3 comments
Closed

trace_transaction and trace_get not working #1833

tjayrush opened this issue Apr 28, 2021 · 3 comments

Comments

@tjayrush
Copy link
Contributor

This is a tracking issue for the PR.

With the recent changes to trace_block, three routines trace_transaction, trace_get, and trace_filter appear to be broken.

trace_transaction:

curl -s --data '{"method":"trace_transaction","params":["0x6df0b4a0d15ae3b925b9819646a0cff4d1bc0a53b294c0d84d884865302d13a5"],"id":"1","jsonrpc":"2.0"}' -H "Content-Type: application/json" -X POST http://localhost:8545

returns 23 traces from OpenEthereum, but zero from TG.

trace_get:

curl -s --data '{"method":"trace_get","params":["0x6df0b4a0d15ae3b925b9819646a0cff4d1bc0a53b294c0d84d884865302d13a5",["0x0"]],"id":"1","jsonrpc":"2.0"}' -H "Content-Type: application/json" -X POST http://localhost:8545

returns the first trace of the above, as it should, from OpenEthereum, but nothing from TG.

Note: trace_filter is also broken (for the same reason), but I will fix that in a different PR.

@Uxio0
Copy link

Uxio0 commented Apr 28, 2021

We see the same, more info: safe-global/safe-transaction-service#246

@tjayrush
Copy link
Contributor Author

PR #1835 re-enabled traces for trace_transaction and trace_get, so I am going to close this issue. There are still a few open issues with tracing. I will create specific issues for those as I fix each one. I'll reference this issue as I create those new issues to make it easier to follow.

@Uxio0
Copy link

Uxio0 commented Apr 29, 2021

safe-global/safe-transaction-service#246

I can confirm is now working like OpenEthereum for the case I posted. Thank you for the fix @tjayrush!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants