Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status review #5

Open
NorthDecoder opened this issue Jun 9, 2015 · 1 comment
Open

Status review #5

NorthDecoder opened this issue Jun 9, 2015 · 1 comment

Comments

@NorthDecoder
Copy link

Wow, you put a lot of work into this code!

These are not feature requests per se, just a few observations to help the next reviewer.

  • The demo.php file has a bunch of references to the ericwenn website that are dead links
    • The demo.php file can be renamed demo.html to test locally as the php is cosmetic
  • Dates have a rectangular icon for each event, but no hint of what the event is.
    • All events appear equal, this is not helpful to the casual user/observer doing a quick scan
    • A rollover/popup hint would be nice.
  • When an event icon is clicked the event detail is shown but the back button fails to work causing the user to be stuck on the event detail.
  • An agenda view would be nice so smart phone users can swipe through it fast.
  • Times imported from Google Calendar appear to be late by one hour
    • ie, google start=1830, kalendar start= 1930
@jxmccall
Copy link

This works very well still with the exception of the time being off by an hour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants