-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
find_use expand_fqcn and goto_definition_scope don't work #76
Comments
Same here, using latest dev build (which right now is 3113) |
Ditto. Same issue, using ST3 v3114 and latest from PC. |
Did anyone found a workaround? |
@hughsaffar not for me atm |
Same problem here, with build 3113 |
I did some digging around in the code. Seems like the row below is always returning an empty array, even when hardcoded a symbol that exists in my project.
https://github.com/erichard/SublimePHPCompanion/blob/master/php_companion/utils.py#L18 Is this a Sublime bug maybe? This is above my Sublime skills, otherwise I would do a PR. EDIT: |
Sorry guys For not replying here. I just don't see what I can do as I can't reproduce the problem on my machine. As @iamanders say, it could be a Sublime bug with the index engine. Hopefully the next build will fix this. |
It's too bad work without this feature, it has saved me a good time. |
Just upgraded to the last beta build (3118) and the problem remains. |
Maybe an issue is referenced in sublime core issue tracker. Please take a look at https://github.com/SublimeTextIssues/Core |
It works for me now, using 3118 under both Windows and Linux :\ |
Thats weird, works for me too now! Same version (3118) as my last comment. Don't think I have made any config changes, or installed/removed any plugins since then. Really happy that it's working now. |
Same here, it was not working yesterday. It works today... really weird. |
This seemed to be an issue with Sublime Text core. Now working in Sublime Text Dev Build 3118 - https://www.sublimetext.com/3dev |
Still not working here ... |
did not work for me as well. I'm on a MBP. |
I disabled all plugins and does not work! Is there a way to force a reindex of the Sublime files? |
I don't think so if there weren't sublime text update. With build 3118 was NOT working, and a few days later it was working. And as some users indicate, it's not working for them. |
@leandromatos The only way I know to force a reindex
Please make sure you don't have any settings that prevent the indexation like |
@erichard A |
@erichard The index directory path is But, I removed the directory and the error continued: |
Followed the steps, got a recreated index message, but still no go when i hit my keybinding for "find_use" { "keys": ["f10"], "command": "find_use" }, Using Dev version 3119 of SL3 I am not however getting the error leandromatos is getting. In the console I am seeing: looking in that directory, there is no Default folder. Seems like that might be an issue? |
ok, actually found that default (OSX).sublime-keymap in the User folder, created a default folder and copied it over. now I no longer get that error, but still "find_use" does not work. |
I had the same issue even after installing 3119. I removed the PHPCompanion package and reinstalled and the problem went away. |
@Gimcrack I tried this, but doesn't work! |
This problem appears today, I have no idea why. Tried to add a I remembered that I've already have seen this workaround for another package, but I am not able to remember which one or where did I find the solution. Hope this could help someone :) |
What did it for me was removing vendor from "folder_exclude_patterns":["vendor",] |
@bobby-drk You need to have your cursor on the |
That's what I'm saying. Having my cursor on the word Geo does nothing. The only time anything gets imported is if I have my cursor over the method name. |
Now using the newest release build of Sublime Text 3 (3126) with complete uninstall of 3114 and reinstall 3126 with reinstall of PhpCompanion and the problem as I outlined in initial issue is exactly the same. I have tried all suggestions in this thread with no success even to the level @bobby-drk outlined. Can provide more info if needed. |
For me there are sometimes which does not work. Nothing seems to take effect and the day after everything works as expected. Really annoying.. |
Here's what worked for me:
It took me about 10 minutes and all settings were saved |
This worked for me! I had to re-map my hot key for the find_use command - which I may have removed previously - but this worked like a charm. Using build 3126. |
@jdrzejb Worked for me too. Just had to wait for the sublime to reindex and I was away :) Using build 3126. |
Can you all try the @jdrzejb workaround above. Seems we are about could close that awful issue 🙏 |
Worked for me too (in two computers) 🎉 #witchcraft hahaha |
Hmmm... I was having the same issue and simply set up a config file ( |
So is it fixed ? I hope so 😄 Is anyone still having problem ? |
@erichard I think this might be a caching issue, per @nickclasener's suggestion, at least his method is what got it working again for me on two different workstations. So it's not that PHP Companion ever stops working or is malfunctioning, just that it's taking forever to cache everything on medium-large projects since the vendors folder can get massive. |
Package is now working for me. @jdrzejb workaround didn't solve the problem. I'm working on Windows machine and can't be sure that I followed exactly. What did work this time however, is a complete uninstall and reinstall of sublime text. If everyone is happy I can close the issue? |
Want to chime in here with a solution for Windows users:
I've waited a few hours and tried again with success so crossing my fingers this is a semi-permanent solution |
Hmm, I really wonder what was on my mind when I disabled indexing in my Sublime Text config 👀 |
I am experiencing this on stable 3143. I think it started after i upgraded, but i was working on a legacy php and javascript for last days. So i cannot know for sure. I also deleted the sublime folder and tried with a clean st3 + php companion. Still the same. But find namespace is working. And this is what i get in console when doing find_use
edit: i downgraded to my old installation, and still the same issue... any help would be so cool! RESOLVED: So this is a case for Mulder and Scully but i solved it. In my
After i deleted it find_use started working. Also setting the key to false, solves to problem. |
I just ran into this issue on stable 3143 and @keevitaja solution worked for me. |
@keevitaja This setting make a call to the php cli. Seems that you don't have php installed on your system. |
correct, i use docker to develop php apps |
Not sure if it helps, but I've added this line to my php companion user settings and it started working again:
|
The find_use was working fine for me for a while, and then it suddenly stopped. Didn't change any config files recently as well as I can't remember any package updates. Certainly there was no SublimeText update (using 3143). Reinstalling package didn't help. my config file was only containing:
Changing this value to false, or removing whole config file didn't help either. Removing SublimeCodeIntel files from Restarted computer as I thought it may help. It didn't. Lastly I've checked the Help > Indexing status, as I removed earlier index files. Waited for it to finish and tried find_use again. It worked. |
I'm on build 3176. Nothing I do seems to work. Not a single key binding works. |
I have the same, tried literally all suggestions, from index to config files to reinstalling fully. the command gets fired by my keybind, but no errors and nothing happening. |
find_use doesn't work for me on some cases, usually on cases where my classes are right under my root app folder. Works in other cases (kinda). |
I seem to found a way to fix that. It doesn't look like problem is in PHP Companion package but Sublime / system setup? I got this problem again, commands stopped working. After some inspection of PHP Companion code I realised that underlying sublime API command Initially I removed sublime index files as I thought they got corrupt or something - no luck. But I noticed sublime fails to recreate index. I realised that I have Elasticsearch and webpack in watch mode runing at the time which were preventing sublime from indexing files. I've stopped them, index was recreated and So I believe the solution may be along this lines
|
Same issue :( |
RESOLU/ RESOLVED 1-Quitter Sublime Text 3. 2-Effacer la Sublime Text 3 du dossier d'Index 3-Ouvrir ST3 et votre projet et attendre l'indexation |
I have closed sublime deleted index, opened sublime and run the GoTo Project Symbols which has reindexed sublime successfully. find_use expand_fqcn and goto_definition_scope are still not working on any assigned key combo or through running the commands from the Command Palette.
import_namespace and insert_php_constructor_property work as expected so the package is working.
find_use and expand_fqcn don't have any output in the console or bottom bar when they are run.
goto_definition_scope has no output in the console but it does say "Unable to find {ClassName}" in the bottom bar when run.
I was successfully running this package on a different machine but this new one no luck! Any suggestions?
The text was updated successfully, but these errors were encountered: