From 29ab9bb60d9347309e811078039cb13105d07658 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=98rjan=20Aare=20J=C3=B8rgensen?= <oajo@equinor.com>
Date: Fri, 27 Dec 2024 13:13:25 +0100
Subject: [PATCH] fix: Housekeeping (adjust HTML landmarks, correct a typo, set
 model page to full height)

---
 src/App.styled.tsx                                   | 2 +-
 src/features/HandleModel/SidePane/SidePane.styled.ts | 4 ++--
 src/pages/AddModel/AddModel.styled.tsx               | 2 +-
 src/pages/Browse/Browse.styled.tsx                   | 2 +-
 src/pages/ModelPages/Model/Model.styled.tsx          | 7 +++++--
 src/pages/ModelPages/Model/Model.tsx                 | 2 +-
 6 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/src/App.styled.tsx b/src/App.styled.tsx
index 00e9ea8c..37529a18 100644
--- a/src/App.styled.tsx
+++ b/src/App.styled.tsx
@@ -1,6 +1,6 @@
 import styled from 'styled-components';
 
-const StyledOutletWrapper = styled.section`
+const StyledOutletWrapper = styled.div`
   height: calc(100% - 128px);
   overflow: auto;
 `;
diff --git a/src/features/HandleModel/SidePane/SidePane.styled.ts b/src/features/HandleModel/SidePane/SidePane.styled.ts
index 204b37f4..a7f8cb13 100644
--- a/src/features/HandleModel/SidePane/SidePane.styled.ts
+++ b/src/features/HandleModel/SidePane/SidePane.styled.ts
@@ -3,8 +3,8 @@ import styled from 'styled-components';
 import { spacings } from '../../../tokens/spacings';
 import { theme } from '../../../tokens/theme';
 
-export const SidebarWrapper = styled.div`
-  heigth: 100%;
+export const SidebarWrapper = styled.aside`
+  height: 100%;
   max-width: 256px;
 `;
 
diff --git a/src/pages/AddModel/AddModel.styled.tsx b/src/pages/AddModel/AddModel.styled.tsx
index 018bad4e..36810bd0 100644
--- a/src/pages/AddModel/AddModel.styled.tsx
+++ b/src/pages/AddModel/AddModel.styled.tsx
@@ -8,7 +8,7 @@ export const PageLayout = styled.div`
   height: 100%;
 `;
 
-export const Content = styled.div`
+export const Content = styled.main`
   display: flex;
   flex-direction: column;
   align-items: flex-start;
diff --git a/src/pages/Browse/Browse.styled.tsx b/src/pages/Browse/Browse.styled.tsx
index e6ae564e..b12cd4a6 100644
--- a/src/pages/Browse/Browse.styled.tsx
+++ b/src/pages/Browse/Browse.styled.tsx
@@ -1,7 +1,7 @@
 import styled from 'styled-components';
 import { spacings } from '../../tokens/spacings';
 
-export const BrowseWrapper = styled.div`
+export const BrowseWrapper = styled.main`
   column-gap: ${spacings.X_LARGE};
   padding: ${spacings.XXX_LARGE} ${spacings.X_LARGE};
 
diff --git a/src/pages/ModelPages/Model/Model.styled.tsx b/src/pages/ModelPages/Model/Model.styled.tsx
index af084160..4a55e587 100644
--- a/src/pages/ModelPages/Model/Model.styled.tsx
+++ b/src/pages/ModelPages/Model/Model.styled.tsx
@@ -20,12 +20,15 @@ export const Wrapper = styled.div`
   display: grid;
   grid-template-areas: 'sidebar content';
   grid-template-columns: 16rem 1fr;
+  height: 100%;
 `;
 
-export const ContentWrapper = styled.div`
+export const ContentWrapper = styled.main`
   grid-area: content;
+  display: flex;
+  flex-flow: column nowrap;
 `;
 
-export const SidebarWrapper = styled.div`
+export const SidebarWrapper = styled.aside`
   grid-area: sidebar;
 `;
diff --git a/src/pages/ModelPages/Model/Model.tsx b/src/pages/ModelPages/Model/Model.tsx
index ab7355b0..7e105c2f 100644
--- a/src/pages/ModelPages/Model/Model.tsx
+++ b/src/pages/ModelPages/Model/Model.tsx
@@ -132,7 +132,7 @@ export const Model = () => {
             size={24}
             value={100}
             variant="indeterminate"
-          />{' '}
+          />
           <Typography variant="body_short">Loading, please wait…</Typography>
         </div>
       </Styled.EmptyPage>