Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Equinor-specific requirements from the FOSS package #313

Closed
kwinkunks opened this issue Jan 19, 2023 · 2 comments
Closed

Remove Equinor-specific requirements from the FOSS package #313

kwinkunks opened this issue Jan 19, 2023 · 2 comments
Labels
maintenance Not a bug now but could be one day, repaying technical debt

Comments

@kwinkunks
Copy link
Member

There are hardcoded business rules in the package, e.g. see #308, #309 and #310. In the case of matrix requirements (Python and RHEL versions in our case), these appear in both the matrix generating code (release_transpiler.py and matrix.py) and in the linter (lint.py).

Assuming #308 deals with that specific case, we should scour the code for other examples. For example, in the code there are:

@kwinkunks kwinkunks added the maintenance Not a bug now but could be one day, repaying technical debt label Jan 19, 2023
@kwinkunks
Copy link
Member Author

See also #316

@eivindjahren eivindjahren added the christmas-review Issues and PRs for Christmas review label Dec 13, 2024
@jonathan-eq jonathan-eq removed the christmas-review Issues and PRs for Christmas review label Dec 17, 2024
@sondreso sondreso added this to SCOUT Jan 3, 2025
@eivindjahren
Copy link
Contributor

I think these changes unfortunately are non-goals for komodo. Instead, we should maybe consider restructuring the project.

@eivindjahren eivindjahren closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2025
@github-project-automation github-project-automation bot moved this to Done in SCOUT Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt
Projects
Status: Done
Development

No branches or pull requests

3 participants