Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the cache/dlprefix/outdir/output arguments #294

Open
kwinkunks opened this issue Jan 9, 2023 · 1 comment
Open

Rename the cache/dlprefix/outdir/output arguments #294

kwinkunks opened this issue Jan 9, 2023 · 1 comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt

Comments

@kwinkunks
Copy link
Member

The same concept, a temporary directory for pip and other build tools to download into, has several names:

  • cache in cli.py (and therefore in the kmd CLI)
  • dlprefix in build.py
  • outdir in komodo.fetch.fetch()
  • output in the CLI implemented by komodo.fetch.py.

So there are at least 4 names for the same thing. This is confusing for the developer, but could lead to confusion for the user too, for example if they pass cache to the CLI, then it complains of a problem with outdir emitted by fetch.py.

It's going to need a DeprecationWarning because who knows who/what is using these various functions.

@kwinkunks kwinkunks added bug maintenance Not a bug now but could be one day, repaying technical debt and removed bug labels Jan 9, 2023
@kwinkunks
Copy link
Member Author

See also #125

@eivindjahren eivindjahren added the christmas-review Issues and PRs for Christmas review label Dec 13, 2024
@jonathan-eq jonathan-eq removed the christmas-review Issues and PRs for Christmas review label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt
Projects
None yet
Development

No branches or pull requests

3 participants