Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry_point for 'missing' scripts #291

Open
kwinkunks opened this issue Jan 6, 2023 · 3 comments
Open

Add entry_point for 'missing' scripts #291

kwinkunks opened this issue Jan 6, 2023 · 3 comments
Labels
good first issue maintenance Not a bug now but could be one day, repaying technical debt

Comments

@kwinkunks
Copy link
Member

The script maintainer.py implements an argparse CLI but has no entry point and can therefore only be run by passing it to the interpreter. Essentially, komodo doesn't 'know' about it.

There may be other scripts like this one, but this is the only one I noticed so far.

@berland
Copy link
Contributor

berland commented Jan 6, 2023

It probably also means that the script is not in use at all, and can also be deleted..

@kwinkunks
Copy link
Member Author

True.

If we like the functionality, it could make sense to have komodo-show take either version or maintainer as a subcommand. So many options...

Either way, if we do want to get rid of it, we should deprecate first.

@kwinkunks kwinkunks added maintenance Not a bug now but could be one day, repaying technical debt and removed bug labels Jan 9, 2023
@kwinkunks
Copy link
Member Author

kwinkunks commented Jan 20, 2023

The script cleanup.py also does not have an entry point. Editing this issue to cover it.

This script also lacks a proper CLI, it just parses sys.argv.

@kwinkunks kwinkunks changed the title Add entry_point for maintainer.py to setup.py Add entry_point for 'missing' scripts Jan 20, 2023
@eivindjahren eivindjahren added the christmas-review Issues and PRs for Christmas review label Dec 13, 2024
@jonathan-eq jonathan-eq removed the christmas-review Issues and PRs for Christmas review label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue maintenance Not a bug now but could be one day, repaying technical debt
Projects
None yet
Development

No branches or pull requests

4 participants