Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should kmd fail more gracefully or offer options when files already exist? #284

Open
kwinkunks opened this issue Jan 3, 2023 · 1 comment
Labels

Comments

@kwinkunks
Copy link
Member

Currently the pip cache and the target environment folder cannot already exist. When flailing around, this can result in some uncaught exceptions and a lot of typing rm this and that.

Pip cache: if cached files/folders exist then line 101 in fetch.py fails with FileExistsError: [Errno 17] File exists. Probably we should use the cache if it's there (it's a cache after all), or if it must not exist then maybe we should just delete it at the end of the build?

Target environment folder: if this already exists then line 54 in cli.py gives: mv: cannot move ‘my-rel-0.0.1/private/mtha/dev/geocomp-release/prefix/my-rel-0.0.1/root’ to ‘my-rel-0.0.1/root’: File exists.

Maybe kmd should check in advance if the target exists already and throw a more informative error, and/or we could have an option to clobber existing — or even use the current shell's noclobber option (off by default in bash, i.e. clobbering is allowed).

@kwinkunks kwinkunks self-assigned this Jan 27, 2023
@kwinkunks kwinkunks added this to SCOUT Jan 27, 2023
@kwinkunks kwinkunks moved this to In Progress in SCOUT Jan 27, 2023
@kwinkunks
Copy link
Member Author

Propose dealing with this along with #326

@xjules xjules moved this from In Progress to Todo in SCOUT Feb 15, 2023
@xjules xjules moved this from Todo to Backlog in SCOUT Apr 28, 2023
@kwinkunks kwinkunks removed their assignment Sep 6, 2023
@eivindjahren eivindjahren added the christmas-review Issues and PRs for Christmas review label Dec 13, 2024
@jonathan-eq jonathan-eq removed the christmas-review Issues and PRs for Christmas review label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

3 participants