You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
, however it only needs a subset of this configuration. We should only pass in the parts of the configuration that are actually required, and split that into smaller config objects.
For example, the queue_config is already part of the constructor, though it is also available from ErtConfig. This might mean shuffling some config options around if they make more sense as part of different config objects. There could for example be one config object related to configuring the ensemble_evaluator, and so forth.
There is probably no need for ensemble_config for the BaseRunModel for example, instead we should probably send in parameter_configs to the run models that require it, and response_configs to the ones that require it.
The text was updated successfully, but these errors were encountered:
The BaseRunModel takes in the ErtConfig as part of the constructor
ert/src/ert/run_models/base_run_model.py
Lines 137 to 146 in 1889e2a
For example, the
queue_config
is already part of the constructor, though it is also available fromErtConfig
. This might mean shuffling some config options around if they make more sense as part of different config objects. There could for example be one config object related to configuring the ensemble_evaluator, and so forth.There is probably no need for
ensemble_config
for theBaseRunModel
for example, instead we should probably send inparameter_configs
to the run models that require it, andresponse_configs
to the ones that require it.The text was updated successfully, but these errors were encountered: