Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ErtConfig from the BaseRunModel #9604

Open
oyvindeide opened this issue Dec 20, 2024 · 0 comments · May be fixed by #9676
Open

Remove ErtConfig from the BaseRunModel #9604

oyvindeide opened this issue Dec 20, 2024 · 0 comments · May be fixed by #9676
Assignees

Comments

@oyvindeide
Copy link
Collaborator

oyvindeide commented Dec 20, 2024

The BaseRunModel takes in the ErtConfig as part of the constructor

self,
config: ErtConfig,
storage: Storage,
queue_config: QueueConfig,
status_queue: SimpleQueue[StatusEvents],
active_realizations: list[bool],
total_iterations: int = 1,
start_iteration: int = 0,
random_seed: int | None = None,
minimum_required_realizations: int = 0,
, however it only needs a subset of this configuration. We should only pass in the parts of the configuration that are actually required, and split that into smaller config objects.

For example, the queue_config is already part of the constructor, though it is also available from ErtConfig. This might mean shuffling some config options around if they make more sense as part of different config objects. There could for example be one config object related to configuring the ensemble_evaluator, and so forth.

There is probably no need for ensemble_config for the BaseRunModel for example, instead we should probably send in parameter_configs to the run models that require it, and response_configs to the ones that require it.

@oyvindeide oyvindeide moved this to Todo in SCOUT Jan 6, 2025
@frode-aarstad frode-aarstad moved this from Todo to In Progress in SCOUT Jan 7, 2025
@frode-aarstad frode-aarstad self-assigned this Jan 7, 2025
@frode-aarstad frode-aarstad linked a pull request Jan 8, 2025 that will close this issue
9 tasks
@frode-aarstad frode-aarstad moved this from In Progress to Ready for Review in SCOUT Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Review
Development

Successfully merging a pull request may close this issue.

2 participants