Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model in EverestConfig marked as optional, but is required #9368

Open
10 tasks
oyvindeide opened this issue Nov 27, 2024 · 0 comments · May be fixed by #9577
Open
10 tasks

model in EverestConfig marked as optional, but is required #9368

oyvindeide opened this issue Nov 27, 2024 · 0 comments · May be fixed by #9577
Assignees
Labels

Comments

@oyvindeide
Copy link
Collaborator

What happened? (You can include a screenshot if it helps explain)

Tried running Everest without model in the config, which is marked as optional, it passed the original validation, but failed with:

Config validation error: Expected realizations when analysing data installation source

Realizations in model config should be a conlist (pydantic type) with min_length=1 and not defaulted. ModelConfig should not have a default value either.

What did you expect to happen?

Expected the config validation to tell me which keyword was missing, in this case:
Missing required model-> realizations

steps to reproduce

Remove the `model` section from for example minimal_config.yml and run the math func.

Environment where bug has been observed

  • python 3.10
  • python 3.11
  • python 3.12
  • macosx
  • rhel7
  • rhel8
  • local queue
  • lsf queue
  • slurm queue
  • openPBS queue
@oyvindeide oyvindeide added the bug label Nov 27, 2024
@oyvindeide oyvindeide moved this to Todo in SCOUT Nov 27, 2024
@frode-aarstad frode-aarstad moved this from Todo to In Progress in SCOUT Nov 29, 2024
@frode-aarstad frode-aarstad moved this from In Progress to Todo in SCOUT Dec 4, 2024
@StephanDeHoop StephanDeHoop self-assigned this Dec 17, 2024
@StephanDeHoop StephanDeHoop moved this from Todo to In Progress in SCOUT Dec 17, 2024
@StephanDeHoop StephanDeHoop linked a pull request Dec 17, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

4 participants