Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DERRF may yield values outside of min max arguments #6166

Closed
Blunde1 opened this issue Sep 25, 2023 · 0 comments · Fixed by #6130
Closed

DERRF may yield values outside of min max arguments #6166

Blunde1 opened this issue Sep 25, 2023 · 0 comments · Fixed by #6130
Assignees
Labels

Comments

@Blunde1
Copy link
Contributor

Blunde1 commented Sep 25, 2023

Describe the bug
Running

y=0.5 * (1 + math.erf((x + _skew) / (_width * np.sqrt(2.0))))

for x+_skew>=9 and _width<1 (the relative size is important) yields a result of exactly y=1.0 due to precision.
This means that the largest value will be y=max+1>max after binning (using floor) and division.

Expected behaviour
All returned values should be between min max for both errf and derrf.
Make tests pass

Screenshots
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant