From e235cede6fc2fa52f070fc94a030c25553c99cd1 Mon Sep 17 00:00:00 2001 From: "Yngve S. Kristiansen" Date: Mon, 18 Nov 2024 09:26:57 +0100 Subject: [PATCH] Comment some potentially to-be-removed code --- src/everest/everest_storage.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/everest/everest_storage.py b/src/everest/everest_storage.py index 32f1ec61c8a..67be2c65c1f 100644 --- a/src/everest/everest_storage.py +++ b/src/everest/everest_storage.py @@ -665,6 +665,11 @@ def _handle_finished_batch_event(self, event: Event): convert_to_maximize(result) for result in event.results ) results: List[FunctionResults | GradientResults] = [] + + # Q: Maybe this whole clause can be removed? + # Not sure why it is there, putting the best function result first + # +-----------------------------------------------------------------+ + # | | best_value = -np.inf best_results = None for item in converted_results: @@ -680,6 +685,8 @@ def _handle_finished_batch_event(self, event: Event): if best_results is not None: results = [best_results, *results] + # | | + # +-----------------------------------------------------------------+ last_batch = -1 _batches = {}