Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancer screening history survey #35

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Cancer screening history survey #35

merged 1 commit into from
Dec 10, 2024

Conversation

we-ai
Copy link

@we-ai we-ai commented Dec 6, 2024

Updates in this PR:

  • Implement requirements of cancer screening history survey (issue #1145)
  • Fix delayed app version refreshing (issue #1171)

@we-ai we-ai requested review from a team, JoeArmani and Gbarra9 and removed request for a team December 6, 2024 22:11
Copy link

@JoeArmani JoeArmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

navigator.serviceWorker
.register("./serviceWorker.js")
.then((registration) => {
registration.onupdatefound = () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I just read up on this.

Copy link

@Gbarra9 Gbarra9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Comment on lines +38 to +39
.catch((err) => {
console.error("Service worker registration failed.", err);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the error handling you added

@we-ai we-ai merged commit ef8724f into dev Dec 10, 2024
@we-ai we-ai deleted the cancer-screening-history branch December 10, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants